Skip to content

Review upstream allow-maintainer-edit permission fix #209

Description

@pedrogaudencio

Problem

Gitea fixed an allow-maintainer-edit permission check issue in v1.26.2.

This is relevant to pull request permission boundaries, especially fork-based PRs. If Forkana has the same behavior, users may be able to grant or use maintainer edit permissions incorrectly.

Upstream fix:

Solution

Review the upstream fix and determine whether Forkana is affected.

Address the following:

  • Check whether Forkana supports allow-maintainer-edit on pull requests
  • Review the permission checks around forked PRs and maintainer edits
  • Backport the upstream fix if the affected code exists
  • Add or adapt tests for users with and without maintainer-edit permissions
  • Confirm legitimate maintainer-edit workflows still behave correctly

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions