static dot#153
Closed
Fil wants to merge 3 commits into
Closed
Conversation
Member
|
I want us to implement bundling (and minification) for the client bundle. Maybe let’s do that first so we have a way to share code between client and server? #61 |
Member
|
(Also SSR for Graphviz is great because it can be quite slow otherwise!!) |
Fil
commented
Dec 4, 2023
Fil
commented
Dec 4, 2023
Contributor
Author
|
superseded by #413 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like it might work, but I'd like to share some code between client rendering and SSR — one is in TypeScript and the other one is JS. This might give us ideas to SSR other types of contents, too.
TODO:
closes #141 for DOT