Strip control characters from localization fields, update app icon (#30)

Author: nickustinov

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Fix submitting a new nomination creating a duplicate draft
 - Fix ASC rate limit errors when saving many locales at once
 - Only save changed locales instead of all locales on store listing and app details
+- Fix control characters from AI models causing ASC save failures on name and subtitle
 - Fix all linting and React compiler errors, make lint failures block CI
 
 ## 1.6.1

public/icon.icns

@@ -231,9 +231,15 @@ export async function POST(request: Request) {
       );
     }
 
+    // Strip control characters from single-line fields (name, subtitle, keywords).
+    // LLMs (especially local models) sometimes output newlines or invisible chars.
+    const singleLineField = field === "keywords" || field === "name" || field === "subtitle";
+    let cleaned = singleLineField
+      ? result.replace(/[\x00-\x1f\x7f\u200b-\u200f\ufeff]/g, "").trim()
+      : result;
+
     // For fix-keywords: split multi-word keywords first (Apple indexes words
     // individually), then strip forbidden words so individual words are caught.
-    let cleaned = result;
     if (action === "fix-keywords") {
       // Split multi-word keywords: "clipboard history" → "clipboard,history"
       const splitWords = (s: string) =>

public/icon.png

@@ -9,10 +9,37 @@ const URL_FIELDS = new Set([
   "privacyChoicesUrl",
 ]);
 
+/** Multi-line fields where newlines (\n) are valid content. */
+const MULTILINE_FIELDS = new Set([
+  "description",
+  "whatsNew",
+  "promotionalText",
+]);
+
+/**
+ * Strip control characters that ASC rejects (null, carriage return, tab,
+ * escape, zero-width chars, etc.). For multi-line fields, preserve \n.
+ */
+function stripControlChars(value: string, allowNewlines: boolean): string {
+  // \x00-\x1f covers null, tab, newline, carriage return, escape, etc.
+  // \x7f is DEL. \u200b-\u200f and \ufeff are zero-width/invisible chars.
+  if (allowNewlines) {
+    // Keep \n, strip everything else
+    return value.replace(/[\x00-\x09\x0b-\x1f\x7f\u200b-\u200f\ufeff]/g, "");
+  }
+  return value.replace(/[\x00-\x1f\x7f\u200b-\u200f\ufeff]/g, "");
+}
+
 function cleanAttributes(attrs: Record<string, unknown>): Record<string, unknown> {
   const cleaned: Record<string, unknown> = {};
   for (const [k, v] of Object.entries(attrs)) {
-    cleaned[k] = URL_FIELDS.has(k) && v === "" ? null : v;
+    if (URL_FIELDS.has(k) && v === "") {
+      cleaned[k] = null;
+    } else if (typeof v === "string") {
+      cleaned[k] = stripControlChars(v, MULTILINE_FIELDS.has(k));
+    } else {
+      cleaned[k] = v;
+    }
   }
   return cleaned;
 }