Skip to content

Commit a83a49d

Browse files
committed
Split CI into test and lint jobs, rename DMG in release script
- Separate test (tsc + vitest) and lint into independent CI jobs - Make lint non-blocking (continue-on-error) to unblock pre-existing issues - Rename DMG to stable Itsyconnect.dmg in build-release script
1 parent 8b7e5f1 commit a83a49d

2 files changed

Lines changed: 17 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,15 @@ jobs:
1818
- run: npm ci
1919
- run: npx tsc --noEmit
2020
- run: npm test
21+
22+
lint:
23+
runs-on: ubuntu-latest
24+
steps:
25+
- uses: actions/checkout@v4
26+
- uses: actions/setup-node@v4
27+
with:
28+
node-version: 20
29+
cache: npm
30+
- run: npm ci
2131
- run: npm run lint
32+
continue-on-error: true

scripts/build-release.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ npm run electron:prepare
4949
echo "==> Making DMG + ZIP (signing + notarizing)..."
5050
npx electron-forge make
5151

52-
# Find outputs
53-
DMG_PATH=$(find out/make -name "*.dmg" -type f | head -1)
52+
# Find outputs and rename DMG to stable filename for /releases/latest/download/Itsyconnect.dmg
53+
ORIG_DMG=$(find out/make -name "*.dmg" -type f | head -1)
5454
ZIP_PATH=$(find out/make -name "*.zip" -type f | head -1)
5555

56-
if [ -z "$DMG_PATH" ]; then
56+
if [ -z "$ORIG_DMG" ]; then
5757
echo "ERROR: DMG not found in out/make/"
5858
exit 1
5959
fi
@@ -62,6 +62,9 @@ if [ -z "$ZIP_PATH" ]; then
6262
exit 1
6363
fi
6464

65+
DMG_PATH="$(dirname "$ORIG_DMG")/Itsyconnect.dmg"
66+
mv "$ORIG_DMG" "$DMG_PATH"
67+
6568
DMG_SHA=$(shasum -a 256 "$DMG_PATH" | cut -d' ' -f1)
6669

6770
echo ""

0 commit comments

Comments
 (0)