nextflow plugins -help: show subcommands#7197
Merged
Merged
Conversation
Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
jorgee
reviewed
Jun 3, 2026
pditommaso
reviewed
Jun 6, 2026
Address review feedback on the plugin usage help: - The usage() default branch aborted on the <plugin-name>:<command> form, so `nextflow plugin nf-hello:greet -help` errored claiming the command was unknown. It now falls back to a plugin-specific usage block for the colon form (pditommaso). - For a genuine unknown sub-command, print the failure reason before the general usage rather than a bare abort (jorgee). - Add CmdPluginUsageTest pinning the usage output for each case. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
Member
Author
|
Addressed the review feedback in 81db3ae:
|
pditommaso
approved these changes
Jun 8, 2026
pditommaso
left a comment
pditommaso
left a comment
Member
There was a problem hiding this comment.
LGTM. The no-arg usage(); return pattern is consistent with the other UsageAware commands (CmdFs, CmdSecret, CmdAuth, CmdModule), and both earlier review comments are addressed.
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
ewels
added a commit
that referenced
this pull request
Jun 8, 2026
PR #7197 made CmdPlugin a UsageAware command with its own usage rendering, which bypassed the -help-json tip that every other command help screen shows. Restore it, and make CmdPlugin SubcommandAware so its statically-known sub-commands (install, create) are surfaced in -help-json - both at the root index and under 'nextflow plugin -help-json' - matching the human help added in #7197. The dynamic <plugin-name>:<command> form is resolved at runtime and stays out. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the available subcommands for
nextflow pluginsin the CLI help.