Skip to content

Commit 49efcdf

Browse files
mschmickingclaude
andcommitted
docs: rename LICENSE.md to THIRD-PARTY-NOTICES.md
Two files both called LICENSE-something, both opening with the full ISC text, read as rival copies of the same licence. That was my error when adding LICENSE for GitHub's detector. LICENSE.md could not simply be deleted: it carries the Lua and LuaFileSystem MIT notices, and MIT requires those to travel with any copy of the code. So the fix is to stop duplicating rather than to remove. LICENSE is now the single statement of this project's licence, and THIRD-PARTY-NOTICES.md holds only the vendored notices, with the duplicated ISC text dropped. Also writes out LuaFileSystem's MIT terms in full instead of saying 'on the same terms as above', which stopped being true once the ISC block above it was removed. Updates the files allowlist, the release tarball guard and the README. Verified: 67 files, LICENSE and THIRD-PARTY-NOTICES.md both present, LICENSE.md gone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent fd1fa25 commit 49efcdf

5 files changed

Lines changed: 60 additions & 61 deletions

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ jobs:
8080
}
8181
const files = entry.files.map(f => f.path);
8282
83-
const needed = ['index.js', 'binding.gyp', 'src/luastate.cc', 'src/nodelua.cc', 'src/utils.cc', 'vendor/lfs/lfs.c', 'README.md', 'LICENSE', 'LICENSE.md'];
83+
const needed = ['index.js', 'binding.gyp', 'src/luastate.cc', 'src/nodelua.cc', 'src/utils.cc', 'vendor/lfs/lfs.c', 'README.md', 'LICENSE', 'THIRD-PARTY-NOTICES.md'];
8484
const missing = needed.filter(n => !files.includes(n));
8585
if (missing.length) {
8686
console.error('missing from tarball:', missing.join(', '));

LICENSE.md

Lines changed: 0 additions & 58 deletions
This file was deleted.

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,4 +350,5 @@ there is no npm token stored in this repository.
350350

351351
## License
352352

353-
ISC — see [LICENSE.md](LICENSE.md), which also covers the vendored Lua and LuaFileSystem sources.
353+
ISC — see [LICENSE](LICENSE). The vendored Lua and LuaFileSystem sources are MIT; their
354+
notices are in [THIRD-PARTY-NOTICES.md](THIRD-PARTY-NOTICES.md).

THIRD-PARTY-NOTICES.md

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
# Third-party notices
2+
3+
This package compiles third-party sources directly into the addon. Both are MIT
4+
licensed, and MIT requires their copyright notices to travel with any copy — which is
5+
why this file exists and ships in the npm tarball.
6+
7+
**This project's own licence is ISC and lives in [LICENSE](LICENSE).** Nothing below
8+
changes it.
9+
10+
## Lua 5.1.5 — `vendor/lua/`
11+
12+
Verbatim copy of the upstream release; see also `vendor/lua/COPYRIGHT`.
13+
14+
Copyright (C) 1994-2012 Lua.org, PUC-Rio.
15+
16+
Permission is hereby granted, free of charge, to any person obtaining a copy
17+
of this software and associated documentation files (the "Software"), to deal
18+
in the Software without restriction, including without limitation the rights
19+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
20+
copies of the Software, and to permit persons to whom the Software is
21+
furnished to do so, subject to the following conditions:
22+
23+
The above copyright notice and this permission notice shall be included in
24+
all copies or substantial portions of the Software.
25+
26+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
27+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
28+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
29+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
30+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
31+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
32+
THE SOFTWARE.
33+
34+
## LuaFileSystem 1.8.0 — `vendor/lfs/`
35+
36+
Verbatim copy of the upstream release; see also `vendor/lfs/LICENSE`.
37+
38+
Copyright (c) 2003-2020 Kepler Project.
39+
40+
Permission is hereby granted, free of charge, to any person obtaining a copy
41+
of this software and associated documentation files (the "Software"), to deal
42+
in the Software without restriction, including without limitation the rights
43+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
44+
copies of the Software, and to permit persons to whom the Software is
45+
furnished to do so, subject to the following conditions:
46+
47+
The above copyright notice and this permission notice shall be included in
48+
all copies or substantial portions of the Software.
49+
50+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
51+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
52+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
53+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
54+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
55+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
56+
THE SOFTWARE.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"vendor/",
2929
"README.md",
3030
"LICENSE",
31-
"LICENSE.md"
31+
"THIRD-PARTY-NOTICES.md"
3232
],
3333
"scripts": {
3434
"install": "node-gyp rebuild",

0 commit comments

Comments
 (0)