wip

Author: felixguendling

exe/batch.cc

@@ -172,8 +172,6 @@ int batch(int ac, char** av) {
   if (rt) {
     apply_canned_rt_update(c, d);
   }
-  // Rental routing needs GBFS data; without this, RENTAL modes silently
-  // produce no offsets in batch runs.
   gbfs::apply_canned_gbfs_update(c, d);
 
   auto response_time = stats{"response_time", 0U};

include/motis/gbfs/update.h

@@ -16,9 +16,6 @@ boost::asio::awaitable<void> update(config const&,
                                     std::shared_ptr<gbfs_data>&,
                                     metrics_registry const*);
 
-// Loads the feeds once, synchronously, from a `dump_gbfs/` dump
-// (`gbfs.canned_gbfs: true`). Counterpart of `apply_canned_rt_update()`, for
-// batch runs that need reproducible rental routing.
 void apply_canned_gbfs_update(config const&, data&);
 
 void run_gbfs_update(boost::asio::io_context&,

src/gbfs/update.cc

@@ -83,20 +83,13 @@ bool is_http_url(std::string_view const url) {
   return url.starts_with("http:") || url.starts_with("https:");
 }
 
-// Dumping is enabled by creating a `dump_gbfs` directory next to the process,
-// exactly like `dump_rt` for GTFS-RT. Every fetched body is written to
-// `dump_gbfs/<feed_id>[/<system_id>]/<name>.json`, which is the layout the
-// directory-based reader (`fetch_file()` with `dir`) expects, so a dump can be
-// replayed with `gbfs.canned_gbfs: true`.
 bool gbfs_dump_enabled() {
   static auto const enabled = std::filesystem::is_directory("dump_gbfs");
   return enabled;
 }
 
 std::filesystem::path gbfs_dump_root() { return {"dump_gbfs"}; }
 
-// `dump_gbfs/<feed id>/`, with sub-feeds ("<manifest id>:<system id>") nested
-// so the layout matches what the directory reader expects.
 std::filesystem::path gbfs_dump_dir(std::string_view const feed_id) {
   auto dir = gbfs_dump_root();
   for (auto pos = std::size_t{0U}; pos <= feed_id.size();) {