Commit db0e30a
docs(solid-no-innerhtml): correct port comment about static-string handling
Bugbot (PR #513) flagged that the rule's header claimed "Static string
values are still flagged because Solid reports them as dangerous when
the rule is left at its default," but the actual code permits a
static string `innerHTML="..."` on a childless element. The code
behaviour is correct — it mirrors upstream's `allowStatic: true`
default — only the comment was wrong.
Rewrites the comment to enumerate the three real diagnostic cases
(`dangerouslySetInnerHTML`, dynamic `innerHTML`, static `innerHTML`
with JSX children) and to note explicitly that childless-static is
intentionally allowed. Also documents the upstream `is-html`
suggestion path as the one omission, so a future reader doesn't
re-flag it.
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>1 parent 265ec80 commit db0e30a
1 file changed
Lines changed: 16 additions & 6 deletions
Lines changed: 16 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
32 | 42 | | |
33 | 43 | | |
34 | 44 | | |
| |||
0 commit comments