fix(solid): add receiver check for console methods, extract shared extractStaticStringValue

- bodyContainsSideEffects in solid-no-effect-derived-state now gates
  console method detection on `node.callee.object.name === "console"`,
  matching the pattern in solid-no-impure-memo. Previously
  `validation.error()` or `myApi.fetch()` would false-positive as
  side effects.
- Extract duplicated extractStaticStringValue from solid-no-innerhtml
  and solid-jsx-no-script-url into utils/extract-static-string-value.

Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

Author: aidenybai

packages/oxlint-plugin-react-doctor/src/plugin/rules/solid/solid-jsx-no-script-url.ts

@@ -1,19 +1,14 @@
 import { defineRule } from "../../utils/define-rule.js";
 import type { EsTreeNode } from "../../utils/es-tree-node.js";
 import type { EsTreeNodeOfType } from "../../utils/es-tree-node-of-type.js";
+import { extractStaticStringValue } from "../../utils/extract-static-string-value.js";
 import { isNodeOfType } from "../../utils/is-node-of-type.js";
 import type { Rule } from "../../utils/rule.js";
 import type { RuleContext } from "../../utils/rule-context.js";
 
-// Mirrors the WHATWG URL parser's pre-scheme step: leading C0
-// controls and U+0020 SPACE are stripped, then ASCII tab / LF / CR
-// characters inside the URL are also filtered out before the
-// scheme is matched. https://url.spec.whatwg.org/#url-parsing
-//
-// Doing the filter in code (and keeping the regex literal free of
-// control characters) avoids `eslint(no-control-regex)` warnings —
-// inline `[\u0000-\u001F]` and `[\r\n\t]*` between letters would
-// trip the lint at every rule-file load.
+// HACK: Mirrors the WHATWG URL parser's pre-scheme step — strip C0
+// controls first, then match scheme — because embedding the C0 range
+// directly in a regex literal trips `no-control-regex`.
 const JAVASCRIPT_SCHEME_PATTERN = /^ *javascript:/i;
 
 const isUrlControlCharacterCode = (characterCode: number): boolean =>
@@ -30,15 +25,6 @@ const stripUrlControlCharacters = (urlValue: string): string => {
 const startsWithJavascriptScheme = (urlValue: string): boolean =>
   JAVASCRIPT_SCHEME_PATTERN.test(stripUrlControlCharacters(urlValue));
 
-const extractStaticStringValue = (node: EsTreeNode | null | undefined): string | null => {
-  if (!node) return null;
-  if (isNodeOfType(node, "Literal") && typeof node.value === "string") return node.value;
-  if (isNodeOfType(node, "TemplateLiteral") && node.expressions.length === 0) {
-    return node.quasis.map((quasi) => quasi.value.cooked ?? "").join("");
-  }
-  return null;
-};
-
 // Port of `solid/jsx-no-script-url` — flags `<a href="javascript:...">`
 // and similar `javascript:` URLs in JSX attributes. Adapted from
 // `eslint-plugin-react`'s rule of the same name.

packages/oxlint-plugin-react-doctor/src/plugin/rules/solid/solid-no-effect-derived-state.ts

@@ -26,6 +26,9 @@ const bodyContainsOnlySetters = (callback: EsTreeNode): boolean => {
   return isSetterCall(callback.body as EsTreeNode);
 };
 
+const SIDE_EFFECT_GLOBAL_CALLS = new Set(["fetch", "alert", "confirm", "prompt"]);
+const CONSOLE_METHODS = new Set(["log", "warn", "error", "info", "debug"]);
+
 const bodyContainsSideEffects = (callback: EsTreeNode): boolean => {
   if (!isFunctionLike(callback)) return false;
   let foundSideEffect = false;
@@ -36,21 +39,23 @@ const bodyContainsSideEffects = (callback: EsTreeNode): boolean => {
       if (isSetterCall(node)) return;
       if (isNodeOfType(node.callee, "MemberExpression")) {
         const property = node.callee.property;
-        if (isNodeOfType(property, "Identifier")) {
-          const methodName = property.name;
-          if (["log", "warn", "error", "info", "debug", "fetch"].includes(methodName)) {
-            foundSideEffect = true;
-            return false;
-          }
-        }
-      }
-      if (isNodeOfType(node.callee, "Identifier")) {
-        const calleeName = node.callee.name;
-        if (["fetch", "alert", "confirm", "prompt"].includes(calleeName)) {
+        if (
+          isNodeOfType(property, "Identifier") &&
+          CONSOLE_METHODS.has(property.name) &&
+          isNodeOfType(node.callee.object, "Identifier") &&
+          node.callee.object.name === "console"
+        ) {
           foundSideEffect = true;
           return false;
         }
       }
+      if (
+        isNodeOfType(node.callee, "Identifier") &&
+        SIDE_EFFECT_GLOBAL_CALLS.has(node.callee.name)
+      ) {
+        foundSideEffect = true;
+        return false;
+      }
     }
     if (isNodeOfType(node, "AwaitExpression")) {
       foundSideEffect = true;

packages/oxlint-plugin-react-doctor/src/plugin/rules/solid/solid-no-innerhtml.ts

@@ -1,6 +1,7 @@
 import { defineRule } from "../../utils/define-rule.js";
 import type { EsTreeNode } from "../../utils/es-tree-node.js";
 import type { EsTreeNodeOfType } from "../../utils/es-tree-node-of-type.js";
+import { extractStaticStringValue } from "../../utils/extract-static-string-value.js";
 import { getJsxAttributeName } from "../../utils/get-jsx-attribute-name.js";
 import { isNodeOfType } from "../../utils/is-node-of-type.js";
 import type { Rule } from "../../utils/rule.js";
@@ -19,15 +20,6 @@ const extractInnerExpression = (attribute: EsTreeNodeOfType<"JSXAttribute">): Es
   return attribute.value as EsTreeNode;
 };
 
-const extractStaticStringValue = (node: EsTreeNode | null): string | null => {
-  if (!node) return null;
-  if (isNodeOfType(node, "Literal") && typeof node.value === "string") return node.value;
-  if (isNodeOfType(node, "TemplateLiteral") && node.expressions.length === 0) {
-    return node.quasis.map((quasi) => quasi.value.cooked ?? "").join("");
-  }
-  return null;
-};
-
 // Port of `solid/no-innerhtml`. Three distinct diagnostics:
 //
 //   1. `dangerouslySetInnerHTML={...}` — always flagged. Solid does

packages/oxlint-plugin-react-doctor/src/plugin/utils/extract-static-string-value.ts

@@ -0,0 +1,11 @@
+import type { EsTreeNode } from "./es-tree-node.js";
+import { isNodeOfType } from "./is-node-of-type.js";
+
+export const extractStaticStringValue = (node: EsTreeNode | null | undefined): string | null => {
+  if (!node) return null;
+  if (isNodeOfType(node, "Literal") && typeof node.value === "string") return node.value;
+  if (isNodeOfType(node, "TemplateLiteral") && node.expressions.length === 0) {
+    return node.quasis.map((quasi) => quasi.value.cooked ?? "").join("");
+  }
+  return null;
+};