Skip to content

Commit bd949a5

Browse files
vanzueCopilot
andcommitted
Address PR integration skill review
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b88f4443-0b18-4d44-ae20-dde46ff2eea8
1 parent 322d634 commit bd949a5

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

.github/actions/spelling/expect/expect.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -525,6 +525,7 @@ EOK
525525
EPres
526526
EQU
527527
ERASEBKGND
528+
EReport
528529
ERRORONEXIT
529530
espt
530531
esrp
@@ -816,6 +817,7 @@ INVALIDARG
816817
INVALIDATERECT
817818
ipch
818819
ipsp
820+
ITE
819821
iterm
820822
itermcolors
821823
itf

.github/skills/pr-integration-test/SKILL.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: pr-integration-test
3-
description: 'Design, implement, and validate Intelligent Terminal integration tests for a target pull request or regression. Use when asked to add PR integration tests, convert a bug fix into E2E coverage, prove existing behavior still works, map tests to the release checklist, or verify Invoke-ItE2EReport marks checklist cases complete.'
3+
description: 'Design, implement, and validate Intelligent Terminal integration tests for a target pull request or regression. Use when asked to add PR integration tests, convert a bug fix into E2E coverage, prove existing behavior still works, map tests to the release checklist, or verify E2E reports mark checklist cases complete.'
44
---
55

66
# PR Integration Test
@@ -86,8 +86,8 @@ single-flight regressions depend on model wording.
8686
only when an exact test name would be misleading or one case intentionally
8787
covers multiple checklist items.
8888
- Run `pwsh -File test/e2e/Set-ChecklistIds.ps1`; never assign or renumber
89-
`Cnnn` IDs manually.
90-
- Run the suite through `Invoke-ItE2EReport.ps1`, not only `Invoke-Pester`, and
89+
stable checklist IDs manually.
90+
- Run the suite through the E2E report driver, not only `Invoke-Pester`, and
9191
inspect `release-report.md` to prove every new ID is `[x]`.
9292
- Verify `Update-ReleaseReport.ps1` too when the suite is expected to support
9393
partial release-signoff runs.
@@ -100,7 +100,7 @@ Do not call the work complete until all of these are true:
100100
verified pre-fix symptom.
101101
- The fixed path passes through the real integration boundary.
102102
- False-positive and replay/idempotency risks are covered where applicable.
103-
- Related pre-existing suites pass, or every skip/failure is explicitly
103+
- Related preexisting suites pass, or every skip/failure is explicitly
104104
classified as environment, model variance, product regression, or test bug.
105105
- New checklist IDs become `[x]` through both applicable report paths.
106106
- The deployed package or executable under test is proven to contain the target

.github/skills/pr-integration-test/references/workflow.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ code, issue reproduction, logs/events, and live behavior when available.
6161
Search before adding helpers:
6262

6363
```powershell
64-
git grep -n -E "<feature|event|setting|command>" -- test/e2e tools/wta/src src/cascadia
64+
git grep -n -E "<pattern>" -- test/e2e tools/wta/src src/cascadia
6565
```
6666

6767
Read:
@@ -92,7 +92,7 @@ Start with the regression, then add only risk-driven controls:
9292

9393
1. **Regression positive:** the exact old failure now reaches the intended final
9494
effect.
95-
2. **Ordinary baseline:** the pre-existing successful or failure path still
95+
2. **Ordinary baseline:** the preexisting successful or failure path still
9696
works.
9797
3. **False-positive control:** a similar but legitimate case remains ignored.
9898
4. **Replay/idempotency:** redraw, retry, duplicate event, or repeated command

0 commit comments

Comments
 (0)