Skip to content

Commit 381c25e

Browse files
fix: address PR review comments
- de-DE.yml: fix German dative case (bei Intelligentes → beim Intelligenten) - en-US Resources.resw: fix XML formatting of <comment> elements - rust-localization.instructions.md: clarify lock rule for pseudo-locale-only vs full lock Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent f9e7d54 commit 381c25e

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/instructions/rust-localization.instructions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ hint.confirm: "Press Enter to confirm" # {Locked="Enter"} keyboard key name
8282
- Full lock (entire value must not be translated): `# {Locked}`
8383
- Pseudo-locale-only lock (real locales translate, pseudo-locales keep English): `# {Locked=qps-ploc,qps-ploca,qps-plocm}`
8484
- Use this for product names like "Intelligent Terminal" that real locales should translate but pseudo-locales should not mangle. This mirrors the `.resw` `{Locked=qps-ploc,qps-ploca,qps-plocm}` convention.
85-
- **Translation rule:** Locked tokens must appear **verbatim** (in English) in all locale files. This matches the `.resw` `{Locked}` convention — see `.github/instructions/localization.instructions.md` for the full list of non-translatable terms.
85+
- **Translation rule:** Tokens marked with `{Locked}` (full lock) or `{Locked="token"}` (token lock) must appear **verbatim** (in English) in all locale files. Tokens marked with `{Locked=qps-ploc,qps-ploca,qps-plocm}` (pseudo-locale-only lock) must be kept verbatim only in pseudo-locale files — real locales should translate them. See `.github/instructions/localization.instructions.md` for the full list of non-translatable terms.
8686

8787
## Context Comments for Ambiguous Strings (REQUIRED)
8888

src/cascadia/CascadiaPackage/Resources/en-US/Resources.resw

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,8 @@
167167
</data>
168168
<data name="AppDescription" xml:space="preserve">
169169
<value>AI-native terminal — agents can understand, fix, and automate terminal workflows</value>
170-
<comment>"agents" here means AI agents (Copilot, Claude, Gemini), not human representatives. "terminal" means a command-line terminal application, not an airport terminal. This is the app store description shown to users.</comment></data>
170+
<comment>"agents" here means AI agents (Copilot, Claude, Gemini), not human representatives. "terminal" means a command-line terminal application, not an airport terminal. This is the app store description shown to users.</comment>
171+
</data>
171172
<data name="AppDescriptionDev" xml:space="preserve">
172173
<value>AI-native terminal — agents can understand, fix, and automate terminal workflows</value>
173174
<comment>{Locked} The dev build will never be seen in multiple languages</comment>
@@ -178,7 +179,8 @@
178179
</data>
179180
<data name="AppDescriptionPre" xml:space="preserve">
180181
<value>Windows Terminal with a preview of upcoming features</value>
181-
<comment>"Terminal" means a command-line terminal application. "Preview" means a pre-release version with upcoming features. This is the app store description for the Preview build.</comment></data>
182+
<comment>"Terminal" means a command-line terminal application. "Preview" means a pre-release version with upcoming features. This is the app store description for the Preview build.</comment>
183+
</data>
182184
<data name="ShellExtension_OpenInTerminalMenuItem_Dev" xml:space="preserve">
183185
<value>Open in Intelligent Terminal</value>
184186
<comment>{Locked} The dev build will never be seen in multiple languages</comment>

tools/wta/locales/de-DE.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Setup screen titles
2-
setup.title.first_run: "Willkommen bei Intelligentes Terminal!"
2+
setup.title.first_run: "Willkommen beim Intelligenten Terminal!"
33
setup.title.agent_missing: "Agent nicht gefunden"
44
setup.title.agent_error: "Verbindung zum Agenten fehlgeschlagen"
55
setup.title.switch_agent: "Agent wechseln"

0 commit comments

Comments
 (0)