Skip to content

Commit 3276cef

Browse files
vanzueCopilot
andauthored
ci: fix spelling workflow killed by stale secpoll workaround (#358)
The check-spelling action (archived, pinned at v0.0.26) had a 'Sorry' security advisory at archival time, which we suppressed via INPUT_IGNORE_SECURITY_ADVISORY=Sorry. That advisory has since been retracted, so secpoll now finds no advisory for v0.0.26 and fatally rejects the still-set env ("ignore_security_advisory was set to 'Sorry' but there is no security advisory for version 0.0.26", exit 200), killing every spelling run. Remove the env to match upstream microsoft/PowerToys, which is pinned to the same SHA and runs cleanly without it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 1b2fce9 commit 3276cef

1 file changed

Lines changed: 10 additions & 15 deletions

File tree

.github/workflows/spelling2.yml

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -76,21 +76,16 @@ on:
7676

7777
permissions: {}
7878

79-
# Workaround for the archival of check-spelling/check-spelling (archived 2026-06-16).
80-
# On archival the maintainer flipped the action's runtime security poll (secpoll)
81-
# to return the advisory 'Sorry' for v0.0.26 -- the final release -- which fatally
82-
# cancels the workflow (exit 200) on every repo pinned to it. There is no fixed
83-
# version to upgrade to. The action exposes an `ignore_security_advisory` input,
84-
# but v0.0.26 never maps it into the secpoll step's environment, so passing it via
85-
# `with:` is silently dropped. secpoll reads the INPUT_IGNORE_SECURITY_ADVISORY env
86-
# var directly, so we set it here (composite action steps inherit workflow-level
87-
# env). The value must exactly match the advisory text 'Sorry'. This keeps the
88-
# (still-executable) archived action running. Caveat: if check-spelling.dev is ever
89-
# taken down, secpoll's lookup returns empty/NXDOMAIN and this var being set will
90-
# instead make secpoll fail ("...but there is no security advisory") -- at which
91-
# point this workflow must be reworked (remove the checker or pin a maintained fork).
92-
env:
93-
INPUT_IGNORE_SECURITY_ADVISORY: Sorry
79+
# Note on the archived action: check-spelling/check-spelling was archived 2026-06-16
80+
# and is pinned at v0.0.26 (cfb6f7e). The action's runtime security poll (secpoll)
81+
# no longer returns any advisory for v0.0.26, so the action runs normally with no
82+
# workaround -- exactly like upstream microsoft/PowerToys, which is pinned to the
83+
# same SHA. We previously set `INPUT_IGNORE_SECURITY_ADVISORY: Sorry` to suppress a
84+
# transient 'Sorry' advisory, but that advisory was retracted; with no advisory
85+
# present, setting that env makes secpoll fatally fail ("ignore_security_advisory
86+
# was set to 'Sorry' but there is no security advisory for version 0.0.26", exit
87+
# 200), so it has been removed. If a real advisory is ever (re)published, either
88+
# remove the checker or pin a maintained fork.
9489

9590
jobs:
9691
spelling:

0 commit comments

Comments
 (0)