Skip to content

Commit 0534e53

Browse files
committed
Address Markdown review feedback
1 parent 776f710 commit 0534e53

3 files changed

Lines changed: 9 additions & 4 deletions

File tree

build/scripts/Generate-WtaThirdPartyNotices.ps1

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,12 @@ while ($stack.Count -gt 0) {
122122
# attribution.
123123
# ---------------------------------------------------------------------------
124124
$attributed = @()
125-
$vendorRoot = [System.IO.Path]::GetFullPath((Join-Path $wtaRoot 'vendor')).TrimEnd('\') + '\'
125+
$directorySeparators = [char[]]@(
126+
[System.IO.Path]::DirectorySeparatorChar,
127+
[System.IO.Path]::AltDirectorySeparatorChar
128+
)
129+
$vendorRoot = [System.IO.Path]::GetFullPath((Join-Path $wtaRoot 'vendor')).TrimEnd($directorySeparators) +
130+
[System.IO.Path]::DirectorySeparatorChar
126131
foreach ($pkgId in $seen) {
127132
$pkg = $packages[$pkgId]
128133
if (-not $pkg) { continue }

tools/wta/src/app_tests.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10557,7 +10557,7 @@ fn completed_turn_layout_change_log_wrap_and_overflow_force_safe_rebuilds() {
1055710557
}
1055810558

1055910559
#[test]
10560-
fn render_chat_materializes_only_viewport_plus_overscan_turns() {
10560+
fn render_chat_materializes_only_viewport_plus_retained_margin_turns() {
1056110561
let mut app = test_app();
1056210562
app.state = ConnectionState::Connected;
1056310563
for index in 0..200 {
@@ -10576,7 +10576,7 @@ fn render_chat_materializes_only_viewport_plus_overscan_turns() {
1057610576
assert!(rendered.contains("RETAINED_VIEWPORT_TURN_199"));
1057710577
assert!(
1057810578
(1..=48).contains(&materialized),
10579-
"a 16-row viewport plus 32-row overscan should materialize at most 48 turns; materialized {materialized}",
10579+
"a 16-row viewport plus 32 retained rows should materialize at most 48 turns; materialized {materialized}",
1058010580
);
1058110581

1058210582
crate::ui::chat::reset_completed_turn_descriptor_lookup_count();

tools/wta/src/ui/chat.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2824,7 +2824,7 @@ mod tests {
28242824

28252825
assert!(
28262826
streaming_markdown_parsed_bytes() < cold_bytes,
2827-
"stable blocks must avoid reparsing every complete prefix",
2827+
"stable blocks must avoid parsing every complete prefix again",
28282828
);
28292829

28302830
let completed_source = tab.streaming_agent_text().expect("completed source");

0 commit comments

Comments
 (0)