Fix cancel teardown shutdown crash#773
Draft
BrainSlugs83 wants to merge 1 commit into
Draft
Conversation
Avoid the 0xC0000005 teardown AV by clearing the OGA log callback before model/ORT teardown, draining canceled sessions before unload, and leaving EP/env globals alive for the process lifetime. Wire cancellation through SessionManager, Session, ChatSession, and web service request tracking so shutdown stops in-flight work before unloading models. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@BrainSlugs83 is attempting to deploy a commit to the MSFT-AIP Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@BrainSlugs83 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a shutdown-time
0xC0000005access violation seen after model unload when tearing down Foundry Local from an embedded host.The crash was reproducible during process shutdown after cancellation/unload. The root issues were:
SessionManager::CancelAll()was effectively a no-op for active chat work;Fix
SessionManager,Session, andChatSessionso active work can be signaled.Validation
Validated by the downstream repro harness and unit suite:
0xC0000005) before the fix.HARNESS_EXIT=0.Scope
This PR intentionally contains only the upstreamable cancel/teardown crash fix.
A downstream-only telemetry preference (
TelemetryLoggerreplaced byNullTelemetry) exists in the local shippable branch, but is intentionally excluded from this PR because it is a product/build preference rather than a general Foundry Local bug fix.