fix(settings): fix unsaved change detection for non-admin-message config items#1062
Open
fullburnen wants to merge 1 commit into
Open
fix(settings): fix unsaved change detection for non-admin-message config items#1062fullburnen wants to merge 1 commit into
fullburnen wants to merge 1 commit into
Conversation
…fig items Add getRadioConfigChangeCount() and getDeviceConfigChangeCount() for individual setting sections. This resolves displaying the count of unsaved changes on the wrong sidebar item. Add normalizeBytes and call it from the Security page so that unset Admin Keys do not trigger unsaved changes when updating the page. The Position page uses useMemo which does not clear rhfState.isDirty. Remove the rhfState.isDirty from hasPending to address it.
|
@fullburnen is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Author
|
How did I miss that the tabs no longer have a dot for changes. |
Author
Looks like it is an existing issue, possibly stemming from memonization in c729d3b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changing settings often results in the unsaved change counter appearing in the wrong sidebar section. Change counts are also incorrect when modifying items in some tabs.
Changes Made
Add getRadioConfigChangeCount() and getDeviceConfigChangeCount() for individual setting sections. This resolves displaying the count of unsaved changes on the wrong sidebar item.
Add normalizeBytes and call it from the Security page so that unset Admin Keys do not trigger unsaved changes when updating the page.
The Position page uses useMemo which does not clear rhfState.isDirty. Remove the rhfState.isDirty from hasPending to address it.
Device -> User is a more complicated change and hasUserChange() is used rather than making a more complex change
Testing Done
Screenshots (if applicable)
Checklist