WebTransportDatagramsWritable and friends#44383
Open
hamishwillee wants to merge 3 commits into
Open
Conversation
Contributor
chrisdavidmills
requested changes
Jun 8, 2026
chrisdavidmills
left a comment
Contributor
There was a problem hiding this comment.
Hi @hamishwillee! I've read through all of these and provided some commentary. Looking mostly pretty good and makes sense.
hamishwillee
commented
Jun 9, 2026
hamishwillee
commented
Jun 9, 2026
hamishwillee
commented
Jun 9, 2026
hamishwillee
commented
Jun 9, 2026
hamishwillee
commented
Jun 9, 2026
hamishwillee
commented
Jun 9, 2026
hamishwillee
commented
Jun 9, 2026
hamishwillee
commented
Jun 9, 2026
hamishwillee
commented
Jun 9, 2026
Collaborator
Author
|
Thanks @chrisdavidmills - Accepted almost all of them. Should be good for another look. |
Comment on lines
+25
to
+27
| typeof transport.datagrams.createWritable === "function" | ||
| ? transport.datagrams.createWritable() | ||
| : transport.datagrams.writable; // Deprecated and non-standard |
Contributor
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| typeof transport.datagrams.createWritable === "function" | |
| ? transport.datagrams.createWritable() | |
| : transport.datagrams.writable; // Deprecated and non-standard | |
| typeof transport.datagrams.createWritable === "function" | |
| ? transport.datagrams.createWritable() | |
| : transport.datagrams.writable; // Deprecated and non-standard |
Comment on lines
+46
to
+48
| typeof transport.datagrams.createWritable === "function" | ||
| ? transport.datagrams.createWritable() | ||
| : transport.datagrams.writable; // Deprecated and non-standard |
Contributor
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| typeof transport.datagrams.createWritable === "function" | |
| ? transport.datagrams.createWritable() | |
| : transport.datagrams.writable; // Deprecated and non-standard | |
| typeof transport.datagrams.createWritable === "function" | |
| ? transport.datagrams.createWritable() | |
| : transport.datagrams.writable; // Deprecated and non-standard |
Co-Authored-By: Hamish Willee <hamishwillee@gmail.com>
aacf0d8 to
b775180
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents most of the new
WebTransportsupport for prioritizing streams/datagrams within asendGroupbased onsendOrderfor the respective stream objects - such asWebTransportDatagramsWritable. This is recently implemented in Safari.I started on this when reviewing #44317 because that wants to refer to an undocumented method I needed to understand. Talking about pulling a thread...
Anyway, I believe this is correct and useful. The only thing missing is the stream equivalent of
WebTransportDatagramsWritable-WebTransportSendStream.