Issue 34349 additional incognito key advice#44358
Open
rebloor wants to merge 1 commit into
Open
Conversation
Contributor
|
Preview URLs (1 page) |
Rob--W
reviewed
Jun 9, 2026
| ## Example | ||
| ## Privacy considerations | ||
|
|
||
| If your extension needs to maintain the privacy expectations of the private browsing mode, omit the `incognito` key from your `manifest.json`. Omitting the key preserves the default behavior where the extension doesn't run in private browsing windows. |
Member
There was a problem hiding this comment.
The blanket advice is not to delete the incognito key. The deletion of the key is conditional on the extension having implemented proper separation of private and non-private browsing data as needed.
The only reason for deletion of the property is if it is set to "spit" mode. In Chrome that results in stronger separation, but Firefox doesn't support "split", so we fall back to spanning behavior with the extension being disabled in private browsing mode (as already documented in the article).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes fix #34349 by adding advice on removing the key and guarding against leaks between private and non-private browsing windows, as per #33661 (comment) and #33661 (review).