feat: synchronize the themes of pdf editor and vscode#45
Open
u-tung wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried synchronizing the CSS variables of VS Code and pdf.js so that VS Code always matches the PDF editor regardless of which theme is used.
I think this works well for the vast majority of themes (at least for all the themes in my VS Code).
2026-06-06.11.09.59.mov
I also think this better solves the dark mode issue: relying on the system light/dark mode setting doesn't always align with the VS Code theme — you might be using a dark VS Code theme while your system is set to light mode.
Related issue
#15