mbtiles tests fail with can execute script on file:tc_dedup?mode=memory&cache=shared

[christophfink]

Hi!

With mbtiles v0.16.0, unit tests started to fail. Specifically, temp_named_mbtiles() seems to not be able to inhibit script execution during the transcoder::tests::transcode_normalized_no_redundant_transforms test.

I’m on Linux and run the tests with the following command line:

export RUSTUP_TOOLCHAIN=stable
export RUST_BACKTRACE=full
cargo test --frozen --all-features --package mbtiles

Below the full backtrace:

---- transcoder::tests::transcode_normalized_no_redundant_transforms stdout ----                                                        
                                                                                                                                                         
thread 'transcoder::tests::transcode_normalized_no_redundant_transforms' (18841) panicked at mbtiles/src/metadata.rs:367:29:            
can execute script on file:tc_dedup?mode=memory&cache=shared                                                                                             
stack backtrace:                                                                                                                                         
   0:     0x5640014ea73a - <<std[a765fd5928b5b598]::sys::backtrace::BacktraceLock>::print::DisplayBacktrace as core[35a6834026b90a1d]::fmt::Display>::fmt
   1:     0x56400150433a - core[35a6834026b90a1d]::fmt::write                                                                                            
   2:     0x5640014efde2 - <alloc[9053f72565c4294]::vec::Vec<u8> as std[a765fd5928b5b598]::io::Write>::write_fmt
   3:     0x5640014c4ecf - std[a765fd5928b5b598]::panicking::default_hook::{closure#0}                                            
   4:     0x5640014e0ef9 - std[a765fd5928b5b598]::panicking::default_hook                                                                                
   5:     0x56400097fbfc - test[9a626e5332d5a6ba]::test_main_with_exit_callback::<test[9a626e5332d5a6ba]::test_main::{closure#0}>::{closure#0}
   6:     0x5640014e1172 - std[a765fd5928b5b598]::panicking::panic_with_hook                                                       
   7:     0x5640014c4f88 - std[a765fd5928b5b598]::panicking::panic_handler::{closure#0}                         
   8:     0x5640014bc4d9 - std[a765fd5928b5b598]::sys::backtrace::__rust_end_short_backtrace::<std[a765fd5928b5b598]::panicking::panic_handler::{closure#
0}, !>                                                                                                                                                   
   9:     0x5640014c5e0d - __rustc[168cb6d8736c2077]::rust_begin_unwind                                                                                    10:     0x564001504ccc - core[35a6834026b90a1d]::panicking::panic_fmt                                                                                  
  11:     0x5640005f7ab4 - mbtiles::metadata::temp_named_mbtiles::{{closure}}::{{closure}}::h06c4294a1dd91f04
                               at /usr/src/debug/mbtiles/martin-mbtiles-v0.16.0/mbtiles/src/metadata.rs:367:29                                     
  12:     0x5640007223c8 - core::result::Result<T,E>::unwrap_or_else::h2456f5c8b680cf1e                                                                                                 at /usr/src/debug/rust/rustc-1.95.0-src/library/core/src/result.rs:1622:23
  13:     0x5640005f78be - mbtiles::metadata::temp_named_mbtiles::{{closure}}::hff3ff9e35d7f3e3c
                               at /usr/src/debug/mbtiles/martin-mbtiles-v0.16.0/mbtiles/src/metadata.rs:367:10
  14:     0x5640005c3429 - mbtiles::transcoder::tests::transcode_normalized_no_redundant_transforms::{{closure}}::hc8a2befcb22c01e3
                               at /usr/src/debug/mbtiles/martin-mbtiles-v0.16.0/mbtiles/src/transcoder.rs:984:79
  15:     0x564000703e0b - <tokio::task::local::RunUntil<T> as core::future::future::Future>::poll::{{closure}}::h6afeb51a2ca23bc7
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/task/local.rs:1076:44
  16:     0x5640006f8996 - tokio::task::local::LocalSet::with::{{closure}}::hd5d3d373bca3b245
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/task/local.rs:827:13
  17:     0x56400061f387 - std::thread::local::LocalKey<T>::try_with::h3278e62fa7a45378
                               at /usr/src/debug/rust/rustc-1.95.0-src/library/std/src/thread/local.rs:513:12
  18:     0x5640006145e1 - std::thread::local::LocalKey<T>::with::hadfb0a9fc032bd59
                               at /usr/src/debug/rust/rustc-1.95.0-src/library/std/src/thread/local.rs:477:20
  19:     0x5640006f65c7 - tokio::task::local::LocalSet::with::h6abfd18547ab2d1b
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/task/local.rs:825:17
  20:     0x564000702510 - <tokio::task::local::RunUntil<T> as core::future::future::Future>::poll::h22b3d62a76f8d392
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/task/local.rs:1066:22
  21:     0x564000701de7 - tokio::task::local::LocalSet::run_until::{{closure}}::hfc12759d9e3ca517
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/task/local.rs:723:19
  22:     0x5640007c1aed - <core::pin::Pin<P> as core::future::future::Future>::poll::h259a127e7603b20b
                               at /usr/src/debug/rust/rustc-1.95.0-src/library/core/src/future/future.rs:133:9
  23:     0x5640007c1aad - <core::pin::Pin<P> as core::future::future::Future>::poll::h24a08542271e52c4
                               at /usr/src/debug/rust/rustc-1.95.0-src/library/core/src/future/future.rs:133:9
  24:     0x5640009160fd - tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}}::{{closure}}::{{closure}}::h26fe33b6cdece7eb
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/scheduler/current_thread/mod.rs:76
9:70
  25:     0x56400090e6bf - tokio::task::coop::with_budget::h958e09ec0a1ccc64
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/task/coop/mod.rs:167:5
  26:     0x56400090e6bf - tokio::task::coop::budget::hec9a45a43652abb3
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/task/coop/mod.rs:133:5
  27:     0x56400090e6bf - tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}}::{{closure}}::h09d90810cb33ec1e
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/scheduler/current_thread/mod.rs:76
9:25
  28:     0x5640008b0a92 - tokio::runtime::scheduler::current_thread::Context::enter::hc94bae511f4e77bc
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/scheduler/current_thread/mod.rs:44
6:19
  29:     0x5640008f4205 - tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}}::h9ae2b065b31ed530
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/scheduler/current_thread/mod.rs:76
8:44
  30:     0x5640008d87c7 - tokio::runtime::scheduler::current_thread::CoreGuard::enter::{{closure}}::he2b68b22601974f3
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/scheduler/current_thread/mod.rs:85
6:68
  31:     0x5640005e1a8e - tokio::runtime::context::scoped::Scoped<T>::set::h5dd056d3d10fb117
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/context/scoped.rs:40:9
  32:     0x564000957a07 - tokio::runtime::context::set_scheduler::{{closure}}::hd068ee36d960b6e3
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/context.rs:176:38
  33:     0x56400062f903 - std::thread::local::LocalKey<T>::try_with::h90f874f8715190b8
                               at /usr/src/debug/rust/rustc-1.95.0-src/library/std/src/thread/local.rs:513:12
  34:     0x564000613931 - std::thread::local::LocalKey<T>::with::h90980a30274c1990
                               at /usr/src/debug/rust/rustc-1.95.0-src/library/std/src/thread/local.rs:477:20
  35:     0x564000955cff - tokio::runtime::context::set_scheduler::h83233b927129c13f
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/context.rs:176:17
  36:     0x5640008cbf68 - tokio::runtime::scheduler::current_thread::CoreGuard::enter::h5628ae3b1af33500
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/scheduler/current_thread/mod.rs:85
6:27
  37:     0x5640008da905 - tokio::runtime::scheduler::current_thread::CoreGuard::block_on::hbd520d0a0ced0e44
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/scheduler/current_thread/mod.rs:75
6:24
  38:     0x564000894e61 - tokio::runtime::scheduler::current_thread::CurrentThread::block_on::{{closure}}::he04987c5bbdcf526
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/scheduler/current_thread/mod.rs:20
0:33
  39:     0x5640006d91e8 - tokio::runtime::context::runtime::enter_runtime::h7421932f8c72fcb5
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/context/runtime.rs:65:16
  40:     0x564000883fa2 - tokio::runtime::scheduler::current_thread::CurrentThread::block_on::h5723e52c5ecd52ba
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/scheduler/current_thread/mod.rs:18
8:9
  41:     0x564000936cf5 - tokio::runtime::runtime::Runtime::block_on_inner::h875d7c4b72a4e0c1
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/runtime.rs:371:52
  42:     0x56400093ab35 - tokio::runtime::runtime::Runtime::block_on::h22a0ca57485e436c
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/runtime/runtime.rs:343:18
  43:     0x5640006f99a2 - tokio::task::local::LocalSet::block_on::h4e7deb27e8451f57
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.50.0/src/task/local.rs:680:12
  44:     0x5640007c4efd - actix_rt::runtime::Runtime::block_on::hcc15d179294dc99c
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/actix-rt-2.11.0/src/runtime.rs:138:20
  45:     0x564000642c4b - actix_rt::system::SystemRunner::block_on::h36f0c1a8f46e803b
                               at /build/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/actix-rt-2.11.0/src/system.rs:240:17
  46:     0x56400060e7e3 - mbtiles::transcoder::tests::transcode_normalized_no_redundant_transforms::h65452766aebcbddb
                               at /usr/src/debug/mbtiles/martin-mbtiles-v0.16.0/mbtiles/src/transcoder.rs:956:5
  47:     0x5640005c2db9 - mbtiles::transcoder::tests::transcode_normalized_no_redundant_transforms::{{closure}}::h3eab923d5b295946
                               at /usr/src/debug/mbtiles/martin-mbtiles-v0.16.0/mbtiles/src/transcoder.rs:957:60
  48:     0x564000537ea8 - core::ops::function::FnOnce::call_once::h4439432e7c1a6ab7
                               at /usr/src/debug/rust/rustc-1.95.0-src/library/core/src/ops/function.rs:250:5
  49:     0x564000973c7b - test[9a626e5332d5a6ba]::__rust_begin_short_backtrace::<core[35a6834026b90a1d]::result::Result<(), alloc[9053f72565c4294]::stri
ng::String>, fn() -> core[35a6834026b90a1d]::result::Result<(), alloc[9053f72565c4294]::string::String>>
  50:     0x5640009806cb - test[9a626e5332d5a6ba]::run_test::{closure#0}
  51:     0x56400097bdc4 - std[a765fd5928b5b598]::sys::backtrace::__rust_begin_short_backtrace::<test[9a626e5332d5a6ba]::run_test::{closure#1}, ()>
  52:     0x5640009832c2 - <std[a765fd5928b5b598]::thread::lifecycle::spawn_unchecked<test[9a626e5332d5a6ba]::run_test::{closure#1}, ()>::{closure#1} as 
core[35a6834026b90a1d]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  53:     0x5640014e94df - <std[a765fd5928b5b598]::sys::thread::unix::Thread>::new::thread_start
  54:     0x7f9dd0cce97a - <unknown>
  55:     0x7f9dd0d522bc - <unknown>
  56:                0x0 - <unknown>


failures:
    transcoder::tests::transcode_normalized_no_redundant_transforms

[CommanderStorm]

Weird.
It does work in CI and on my machine

What is your SQLitr/rust versions?

[christophfink]

That’s rust 1.95.0, no external sqlite (current system version would be 3.53.0)

I’m building in a chroot (it’s a build script for the Arch User Repository), might be that there are undocumented dependencies required (possibly external to rust)?

[CommanderStorm]

Thank you for maintaining that.

I think that the check command likely should not execute our tests.
We use the justfile right here https://github.com/maplibre/martin/blob/main/justfile
We test our code in CI, so you can assume that anything that gets the git tag has passed this.

Maybe mbtiles --help to see that the binary works?
Not sure.

[christophfink]

The binary works, no issues there, but I consider testing against distribution-local environments good practice when packaging. I’ll skip the test, but I still wonder whether being able to execute SQL in a temp directory is a (low threat) security issue that might pop up in different envs too?

[CommanderStorm]

security issue?
What do you mean with that?
Where?

The tests you are running are for not the binary, they are for the library.

We have some tests for the binary, see tests/test.sh
Could be more through, but that is another story.

[christophfink]

I just assumed there is a reason for testing whether or not sql scripts can be executed in temporary directories

[CommanderStorm]

No, temp_named_mbtiles() should just be that, a temporary mbtiles file.
It is alive during the test and does not surive longer.

We migrated from having opake sqlite blobs in the repo to this because of the "better observabiltiy" and "better security", but honestly this has been a bit more pain than we originally thought.