Skip to content

Commit b483091

Browse files
jjerphanHind-M
andcommitted
Address review comments
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Hind Montassif <hind.montassif@gmail.com>
1 parent 7b94c76 commit b483091

1 file changed

Lines changed: 1 addition & 15 deletions

File tree

libmamba/tests/src/core/test_sharded_repodata_integration.cpp

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
namespace mamba
4545
{
4646
std::vector<std::string> extract_package_names_from_specs(const std::vector<std::string>& specs);
47-
std::vector<std::string> read_explicit_urls(const fs::u8path& path);
4847
void add_python_related_roots_if_python_requested(std::vector<std::string>& root_packages);
4948
std::pair<solver::libsolv::Database, MultiPackageCache> prepare_solver_context(
5049
Context& ctx,
@@ -453,19 +452,6 @@ namespace
453452
}
454453
}
455454

456-
auto read_explicit_urls(const fs::u8path& path) -> std::vector<std::string>
457-
{
458-
std::vector<std::string> urls;
459-
for (const auto& line : read_lines(path))
460-
{
461-
if (line.starts_with("http://") || line.starts_with("https://"))
462-
{
463-
urls.push_back(line);
464-
}
465-
}
466-
return urls;
467-
}
468-
469455
}
470456

471457
TEST_CASE("Sharded repodata - load_channels accepts root_packages", "[mamba::core][sharded][.integration]")
@@ -967,7 +953,7 @@ TEST_CASE("Sharded repodata - minrk gist downgrade non-regression", "[mamba::cor
967953
init_channels(ctx, channel_context);
968954
ctx.prefix_params.target_prefix = prefix_path;
969955

970-
const auto explicit_urls = read_explicit_urls(
956+
const auto explicit_urls = mambatests::read_explicit_urls(
971957
mambatests::test_data_dir / "env_file/minrk_environment.py-3.9-linux-64.lock"
972958
);
973959
REQUIRE(explicit_urls.size() >= 150);

0 commit comments

Comments
 (0)