Address review comments

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Hind Montassif <hind.montassif@gmail.com>

Author: jjerphan

libmamba/tests/src/core/test_sharded_repodata_integration.cpp

@@ -44,7 +44,6 @@
 namespace mamba
 {
     std::vector<std::string> extract_package_names_from_specs(const std::vector<std::string>& specs);
-    std::vector<std::string> read_explicit_urls(const fs::u8path& path);
     void add_python_related_roots_if_python_requested(std::vector<std::string>& root_packages);
     std::pair<solver::libsolv::Database, MultiPackageCache> prepare_solver_context(
         Context& ctx,
@@ -449,19 +448,6 @@ namespace
         }
     }
 
-    auto read_explicit_urls(const fs::u8path& path) -> std::vector<std::string>
-    {
-        std::vector<std::string> urls;
-        for (const auto& line : read_lines(path))
-        {
-            if (line.starts_with("http://") || line.starts_with("https://"))
-            {
-                urls.push_back(line);
-            }
-        }
-        return urls;
-    }
-
 }
 
 TEST_CASE("Sharded repodata - load_channels accepts root_packages", "[mamba::core][sharded][.integration]")
@@ -1002,7 +988,7 @@ TEST_CASE("Sharded repodata - minrk gist downgrade non-regression", "[mamba::cor
     auto channel_context = ChannelContext::make_conda_compatible(ctx);
     init_channels(ctx, channel_context);
 
-    const auto explicit_urls = read_explicit_urls(
+    const auto explicit_urls = mambatests::read_explicit_urls(
         mambatests::test_data_dir / "env_file/minrk_environment.py-3.9-linux-64.lock"
     );
     REQUIRE(explicit_urls.size() >= 150);