Skip to content

Potentially an issue in ubuntu_install_prereqs.sh? #6

Description

@mal-w

I'm not really a bash expert but this code was causing issues... It seemed like I was never getting passed the lsb_release checks... Of all things, removing the -e from the set worked... as you can see in the below diff...

-set -euo pipefail
+set -uo pipefail
 IFS=$'\n\t'
 
 # Check if it's Ubuntu 18.04 or 20.04
+# I believe there is a lack of compatibility between using the -e and the following
+# code...
 lsb_release -d | grep -qi '18.04'; is_ubuntu_18=$?
 lsb_release -d | grep -qi '20.04'; is_ubuntu_20=$?
 if [ $is_ubuntu_18 -ne 0 -a $is_ubuntu_20 -ne 0 ]; then

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions