Fix crash when http is started then stopped so webserver reference in authentication module is no more valid

Fix AuthenticationService starting logic because started too late in process
Transfer http registration/unregistration  to AuthenticationService fully to http server  itself
Add several sanity check to avoid call to not existing webserver during life cycle
thanks to @RafOSS-br for pointing this out

Author: luc-github

esp3d/src/core/esp3d.cpp

@@ -107,6 +107,12 @@ bool Esp3D::begin() {
     restart_now();
   }
 
+#ifdef AUTHENTICATION_FEATURE
+  // Passwords must be loaded before any command channel (serial, USB serial,
+  // network, ...) can start dispatching commands.
+  AuthenticationService::begin();
+#endif  // AUTHENTICATION_FEATURE
+
   esp3d_commands.getOutputClient(true);
 
   #if defined(USB_SERIAL_FEATURE)
@@ -166,9 +172,6 @@ bool Esp3D::begin() {
   esp3d_gcode_host.processFile(ESP_AUTOSTART_SCRIPT_FILE);
 #endif  // ESP_AUTOSTART_FEATURE
 #endif  // GCODE_HOST_FEATURE
-#ifdef AUTHENTICATION_FEATURE
-  AuthenticationService::begin();
-#endif  // AUTHENTICATION_FEATURE
   esp3d_log("Esp3d Started");
   _started = true;
   return res;

esp3d/src/modules/authentication/authentication_service.cpp

@@ -122,19 +122,23 @@ bool AuthenticationService::begin() {
 }
 
 #if defined(HTTP_FEATURE)
-bool AuthenticationService::begin_session(Authwebserver *webserver) {
+bool AuthenticationService::attachWebServer(Authwebserver *webserver) {
   _webserver = webserver;
   // value is in ms but storage is in min
   _sessionTimeout = 1000 * 60 * ESP3DSettings::readByte(ESP_SESSION_TIMEOUT);
   return true;
 }
-#endif  // HTTP_FEATURE
 
-void AuthenticationService::end() {
-#if defined(HTTP_FEATURE)
+void AuthenticationService::detachWebServer() {
   _webserver = nullptr;
   ClearAllSessions();
+}
 #endif  // HTTP_FEATURE
+
+void AuthenticationService::end() {
+  // webserver attach/detach and HTTP session lifecycle are now owned by
+  // HTTP_Server (see attachWebServer/detachWebServer) to avoid this being
+  // called out of order relative to HTTP_Server::begin()/end().
 }
 
 void AuthenticationService::update() {
@@ -187,6 +191,10 @@ char *AuthenticationService::create_session_ID() {
   for (int i = 0; i < 17; i++) {
     sessionID[i] = '\0';
   }
+  if (!_webserver) {
+    strcpy(sessionID, "NONE");
+    return sessionID;
+  }
   // get time
   uint32_t now = millis();
   // get remote IP
@@ -215,6 +223,9 @@ bool AuthenticationService::ClearAllSessions() {
 }
 
 bool AuthenticationService::ClearCurrentHttpSession() {
+  if (!_webserver) {
+    return false;
+  }
   String cookie = _webserver->header("Cookie");
   int pos = cookie.indexOf("ESPSESSIONID=");
   String sessionID;
@@ -228,6 +239,9 @@ bool AuthenticationService::ClearCurrentHttpSession() {
 bool AuthenticationService::CreateSession(ESP3DAuthenticationLevel auth_level,
                                           ESP3DClientType client_type,
                                           const char *session_ID) {
+  if (!_webserver) {
+    return false;
+  }
   auth_ip *current_auth = (auth_ip *)malloc(sizeof(auth_ip));
   if (!current_auth) {
     esp3d_log_e("Error allocating memory for session");

esp3d/src/modules/authentication/authentication_service.h

@@ -63,7 +63,8 @@ class AuthenticationService {
   static void update();
   static bool isuser(const char *pwd);
 #if defined(HTTP_FEATURE)
-  static bool begin_session(Authwebserver *webserver);
+  static bool attachWebServer(Authwebserver *webserver);
+  static void detachWebServer();
   static uint32_t setSessionTimeout(uint32_t timeout);
   static uint32_t getSessionTimeout();
   static uint32_t getSessionRemaining(const char *sessionID);

esp3d/src/modules/http/http_server.cpp

@@ -244,7 +244,7 @@ bool HTTP_Server::begin() {
   _webserver->collectHeaders(headerkeys, headerkeyssize);
   _webserver->begin();
 #ifdef AUTHENTICATION_FEATURE
-  AuthenticationService::begin_session(_webserver);
+  AuthenticationService::attachWebServer(_webserver);
 #endif  // AUTHENTICATION_FEATURE
 
   _started = no_error;
@@ -334,6 +334,9 @@ Embedded; http://www.esp3d.io) Host: http://192.168.0.1:8181
 void HTTP_Server::end() {
   _started = false;
   _upload_status = UPLOAD_STATUS_NONE;
+#ifdef AUTHENTICATION_FEATURE
+  AuthenticationService::detachWebServer();
+#endif  // AUTHENTICATION_FEATURE
   if (_webserver) {
     _webserver->stop();
     delete _webserver;