[rv_core_ibex] Add u-mode performance counters and mcounteren#30135
Open
SamuelRiedel wants to merge 3 commits into
Open
[rv_core_ibex] Add u-mode performance counters and mcounteren#30135SamuelRiedel wants to merge 3 commits into
mcounteren#30135SamuelRiedel wants to merge 3 commits into
Conversation
SamuelRiedel
force-pushed
the
mcounteren
branch
2 times, most recently
from
3baeac4 to
a204ac4
Compare
SamuelRiedel
requested review from
gautschimi,
rswarbrick and
timothytrippel
and removed request for
a team
gautschimi
approved these changes
Jun 1, 2026
rswarbrick
reviewed
Jun 3, 2026
rswarbrick
left a comment
rswarbrick
left a comment
Contributor
There was a problem hiding this comment.
Should the "Add missing rvfi ports" commit be squashed with the vendoring update? Otherwise, I think we have a (slightly) broken intermediate state of the repository?
rswarbrick
reviewed
Jun 3, 2026
| regwen); | ||
|
|
||
| // Since MCOUNTEREN_WRITABLE is True, writes to mcounteren should succeed. | ||
| csr_write_mcounteren(0x5); |
Contributor
There was a problem hiding this comment.
Why is this using a hex constant instead of a define?
(Maybe the value doesn't really matter? But it still makes sense to stick it in a variable to avoid having to write a magic number in multiple places)
Contributor
Author
There was a problem hiding this comment.
There is no good reason for this. I added a define now and fixed it.
Contributor
Author
Yes good point. I will squash the two once we merge the Ibex PR and I vendor in Ibex from the main branch. |
Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
Update code from upstream repository https://github.com/lowRISC/ibex.git to revision aae4809aea170fc605bdaa64a70a13efd2408829 * [dv] Check u-mode counter alias the correct m-mode counter (Samuel Riedel) * [formal] Exclude u-mode counters from formal verification (Samuel Riedel) * [doc] Document the newly added performance counters (Samuel Riedel) * [dv] Add directed test for mcounteren lock signal (Samuel Riedel) * [dv] Add `mcounteren` directed test (Samuel Riedel) * [dv] Fix ordering in `directed_testlist.yml` (Samuel Riedel) * [dv] Implement Ibex-specific mcounteren behavior in cosim (Samuel Riedel) * [rtl] Add input to lock mcounteren (Samuel Riedel) * [rtl] Add unpriviledged counter/timers (Samuel Riedel) * [rtl] Add register for `mcounteren` (Samuel Riedel) * [rtl] Fix incrementing `minstret` after setting it (Samuel Riedel) * [rtl] Fix speculative increment of `minstret` (Samuel Riedel) * [syn] Fix scripts for new vendored lowrisc_ip (Harry Callahan) * [syn] Add nix devShell for example synthesis flow (Harry Callahan) * [dv] Fixup explicit static lifetime on initializer by seperating decl from assign. (Harry Callahan) * [vendor/google_riscv-dv] Add VCS -Xcflags to suppress build warnings (Harry Callahan) * [vendor/google_riscv-dv] use env bash and non-absolute bash paths (Harry Callahan) * [rtl] Explicitly define mapping to `prim_generic` for linter targets (Samuel Riedel) * [rtl] Fix prim_generic mapping in ibex_top (Samuel Riedel) * [rtl] Move prim_generic dependency to ibex_top (Samuel Riedel) * [doc] Ibex Concierge updated (Marno van der Maas) Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mcounterenCSR to control which u-mode counters are accessiblemcounterenCSR can be locked through an input signal to prevent modifying it even in m-modemcounteren_writableregister inrv_core_ibexdriving the above signal. This register is lockable with themcounteren_writable_regwenregister.ToDo:
mcounterenregister in Ibexmcounterenregister ibex#2403 is merged