Apply root svg transform after the viewBox mapping#1068
Open
StefanoD wants to merge 1 commit into
Open
Conversation
A `transform` on the outermost `svg` element is applied in the SVG viewport coordinate system, i.e. after the viewBox-to-viewport mapping, matching Chromium, Firefox and Inkscape. Combine it with the viewBox transform in `convert_doc` (wrapping it) and skip it in `convert_group` for the root `svg`. Fixes linebender#899 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #899.
Problem
A
transformon the outermost<svg>combined with aviewBoxrendereddifferently from Chromium/Firefox/Inkscape. resvg applied the transform inside
the viewBox space, clipping content into the corner.
Fix
The
transformon the outermost<svg>is a CSS transform in the SVG viewportcoordinate system, i.e. applied after the viewBox-to-viewport mapping. Combine
it with the viewBox transform in
convert_docso it wraps the viewBox mapping,and skip it in
convert_groupfor the root<svg>to avoid applying it twice.Testing
root_svg_transform_with_viewboxandnested_svg_transform_still_applies.resvgrender tests pass.Generated by Claude