load content keeps 2 files open when playing a networked rom

[i30817]

Is there an existing issue for this?

• This is a bug in RetroArch frontend
• I have searched the existing issues

Description

This is a bug that makes using a network filesystem like webdav over android and rsaf much much slower.

Apparently either because of the server, or rsaf or just the nature of open() over a network, keeping two files open at the same time destroys performance

I know this because rsaf says how many files it has open. If I load a game from a playlist, its "1" (or one at a time for cue/bins I suppose) for "load content" of a single file it's "2" and performance is much worse

I think what's happening is that the filebrowser never closes the directory it reads even as the game starts so the game plays in the load content case (which uses the filebrowser) with two files open.

Expected behavior

Rsaf only reporting 1 file open just like it does when a game is loaded from playlists/when you stop using the filebrowser resources used like open files get freed.

Steps to reproduce the bug

Pretty difficult. Have a webdav server in the same WiFi network as a android phone, install rsaf and configure a webdav entry there, load up retroarch and load that directory as a authorized SAF uri, then scan 1 game there in a playlist and compare the performance of loading from load content or the playlist and notice rsaf saying playlist has 1 file open and load content has 2.

Version/Commit

1.22.2 (nightly)

Bisect Results

No response

Present in the nightly version

Yes, this is reproduced in the nightly build

Platform & operating system

android

Affected Cores

all

Environment information

No response

Relevant log output

[i30817]

For the same performance reason I request if youre thinking of adding multiprocessing/threading to the scanner, have a way to turn that off. If two files open are enough to destroy emulator performance, I dont know what many open files in a scan would do, but it would probably freeze.