test(plugins): restore image-fallback, cache-failure, and config-precedence coverage

Amp-Thread-ID: https://jieli.app/threads/T-b2e20e80-1c45-4d61-bb27-4234f223abe0

Author: burugo

plugins/claude-code/tests/runtime-node.test.mjs

@@ -276,9 +276,47 @@ test("normalizes Claude images and attachment cache behavior", async () => {
     assert.equal(first, "https://jieli.example.test/attachments/cached.png");
     assert.equal(second, "https://jieli.example.test/attachments/cached.png");
     assert.deepEqual(calls, [imagePath]);
+
+    const failingCalls = [];
+    const failingUpload = async (path) => {
+      failingCalls.push(path);
+      throw new Error("backend is down");
+    };
+    const otherImage = join(tmp, "2.png");
+    writeFileSync(otherImage, Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a]));
+    await assert.rejects(() => runtime.uploadAttachmentCached(otherImage, "https://jieli.example.test/", "secret", failingUpload), /backend is down/);
+    await assert.rejects(() => runtime.uploadAttachmentCached(otherImage, "https://jieli.example.test/", "secret", failingUpload), /backend is down/);
+    assert.deepEqual(failingCalls, [otherImage, otherImage]);
   });
 });
 
+test("keeps the existing image label when the uploader fails instead of inserting a placeholder", async () => {
+  const tmp = makeTempDir();
+  const imagePath = join(tmp, "1.png");
+  writeFileSync(imagePath, Buffer.from([0x89, 0x50, 0x4e, 0x47]));
+  const transcript = join(tmp, "session.jsonl");
+  writeJsonl(transcript, [
+    {
+      type: "user",
+      uuid: "u-image-fallback",
+      sessionId: "cc-image-fallback",
+      message: { role: "user", content: [{ type: "text", text: "我测试下图片：\n\n[Image #1]\n你看到了什么" }, { type: "image", source: imagePath }] },
+    },
+  ]);
+
+  const payload = await runtime.buildPayloadFromHook(
+    { session_id: "cc-image-fallback", transcript_path: transcript, cwd: "/Users/alice/work/jieli" },
+    "https://jieli.example.test",
+    async () => {
+      throw new Error("backend is down");
+    },
+  );
+
+  assert.equal(payload.thread.messages.length, 1);
+  assert.equal(payload.thread.messages[0].content, "我测试下图片：\n\n[Image #1]\n你看到了什么");
+  assert.doesNotMatch(JSON.stringify(payload), /\[Image unavailable\]/);
+});
+
 test("handles Claude model aliases, local command noise, loaded skills, and split assistant messages", async () => {
   const tmp = makeTempDir();
   const transcript = join(tmp, "session.jsonl");
@@ -361,6 +399,23 @@ test("configuration, upload, lock, and transcript flush helpers match hook behav
     assert.deepEqual(runtime.buildMissingConfigHookResponse("userpromptsubmit", ["JIELI_API_KEY"]), {});
   });
 
+  const settingsHome = makeTempDir();
+  mkdirSync(join(settingsHome, ".config", "jieli"), { recursive: true });
+  writeFileSync(
+    join(settingsHome, ".config", "jieli", "settings.json"),
+    JSON.stringify({ api_key: "settings-key", base_url: "https://settings.example.test/" }),
+    "utf8",
+  );
+  await withEnv({ HOME: settingsHome, JIELI_API_KEY: undefined, CLAUDE_PLUGIN_OPTION_API_KEY: undefined, JIELI_BASE_URL: undefined }, async () => {
+    assert.deepEqual(runtime.missingConfigVars(), []);
+    assert.equal(runtime.requiredEnv("JIELI_API_KEY", "CLAUDE_PLUGIN_OPTION_API_KEY"), "settings-key");
+    assert.equal(runtime.optionalEnv("JIELI_BASE_URL", "CLAUDE_PLUGIN_OPTION_BASE_URL"), "https://settings.example.test");
+  });
+  await withEnv({ HOME: settingsHome, JIELI_API_KEY: "env-key", JIELI_BASE_URL: "https://env.example.test/" }, async () => {
+    assert.equal(runtime.requiredEnv("JIELI_API_KEY", "CLAUDE_PLUGIN_OPTION_API_KEY"), "env-key");
+    assert.equal(runtime.optionalEnv("JIELI_BASE_URL", "CLAUDE_PLUGIN_OPTION_BASE_URL"), "https://env.example.test/");
+  });
+
   const { server, state } = createMockJieliServer();
   const baseUrl = await listen(server);
   state.baseUrl = baseUrl;

plugins/codex/tests/runtime-node.test.mjs

@@ -268,9 +268,43 @@ test("normalizes Codex repo metadata, data URL images, local image events, and a
     assert.equal(first, "https://jieli.example.test/attachments/cached.png");
     assert.equal(second, "https://jieli.example.test/attachments/cached.png");
     assert.deepEqual(calls, [imagePath]);
+
+    const failingCalls = [];
+    const failingUpload = async (path) => {
+      failingCalls.push(path);
+      throw new Error("backend is down");
+    };
+    const otherImage = join(tmp, "2.png");
+    writeFileSync(otherImage, Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a]));
+    await assert.rejects(() => runtime.uploadAttachmentCached(otherImage, "https://jieli.example.test/", "secret", failingUpload), /backend is down/);
+    await assert.rejects(() => runtime.uploadAttachmentCached(otherImage, "https://jieli.example.test/", "secret", failingUpload), /backend is down/);
+    assert.deepEqual(failingCalls, [otherImage, otherImage]);
   });
 });
 
+test("keeps the existing image label when the Codex uploader fails instead of inserting a placeholder", async () => {
+  const tmp = makeTempDir();
+  const imagePath = join(tmp, "1.png");
+  writeFileSync(imagePath, Buffer.from([0x89, 0x50, 0x4e, 0x47]));
+  const transcript = join(tmp, "session.jsonl");
+  writeJsonl(transcript, [
+    { type: "session_meta", payload: { id: "codex-image-fallback", cwd: "/Users/alice/work/jieli" } },
+    { type: "event_msg", payload: { type: "user_message", message: "ok [Image #1] what is this?", images: [], local_images: [imagePath], text_elements: [{ placeholder: "[Image #1]" }] } },
+  ]);
+
+  const payload = await runtime.buildPayloadFromHook(
+    { session_id: "codex-image-fallback", transcript_path: transcript },
+    "https://jieli.example.test",
+    async () => {
+      throw new Error("backend is down");
+    },
+  );
+
+  assert.equal(payload.thread.messages.length, 1);
+  assert.equal(payload.thread.messages[0].content, "ok [Image #1] what is this?");
+  assert.doesNotMatch(JSON.stringify(payload), /\[Image unavailable\]/);
+});
+
 test("configuration, upload, lock, session mapping, and missing transcript behavior match Codex hooks", async () => {
   const tmp = makeTempDir();
   await withEnv({ HOME: tmp, JIELI_API_KEY: undefined, JIELI_BASE_URL: undefined }, async () => {
@@ -289,6 +323,11 @@ test("configuration, upload, lock, session mapping, and missing transcript behav
     assert.equal(runtime.optionalEnv("JIELI_BASE_URL"), "https://jieli.example.test");
   });
 
+  await withEnv({ HOME: tmp, JIELI_API_KEY: "env-key", JIELI_BASE_URL: "https://env.example.test/" }, async () => {
+    assert.equal(runtime.requiredEnv("JIELI_API_KEY"), "env-key");
+    assert.equal(runtime.optionalEnv("JIELI_BASE_URL"), "https://env.example.test");
+  });
+
   await withEnv({ HOME: tmp }, async () => {
     runtime.writeSessionMapping("codex-map", "https://jieli.example.test/", "T-codex-map", "/tmp/session.jsonl");
     const path = join(tmp, ".jieli", "codex-sessions.json");