Stop generating a LICENSE file automatically

Author: jfmengels

CHANGELOG.md

@@ -8,6 +8,7 @@
 - Made import cycle error look better for modules with names that are only a single character.
 - Fix prepare-offline help text.
 - Breaking change for local dev testing: Replaced `LOCAL_ELM_REVIEW_SRC=/path/to/elm-review/src` by `LOCAL_ELM_REVIEW=/path/to/elm-review`.
+- When running `elm-review new-package`, the `LICENSE` file will now not be generated automatically. Instead, a manual step has been added in the generated `MAINTENANCE.md` file.
 
 ## [2.13.5] - 2025-12-30
 

lib/new-package.js

@@ -5,7 +5,6 @@
  * @import {Options, RuleType} from './types/options';
  * @import {Path} from './types/path';
  */
-const childProcess = require('node:child_process');
 const path = require('node:path');
 const chalk = require('chalk');
 const prompts = require('prompts');
@@ -302,29 +301,6 @@ ElmjutsuDumMyM0DuL3.elm
     ['ISSUE_TEMPLATE/new-rule-idea.md', 'workflows/test.yml']
   );
 
-  Spinner.succeedAndNowDo(
-    `Adding LICENSE ${chalk.grey(`npx license ${license}`)}`,
-    options.report
-  );
-  const licenseArgs = options.forTests ? '--name "Test User" --year 2020' : '';
-  try {
-    childProcess.execSync(
-      // TODO(@lishaduck): Evaluate calling the API instead.
-      `npx license ${license} --projectName "${authorName}/${packageName}" ${licenseArgs}`,
-      {
-        cwd: dir,
-        stdio: ['ignore', 'ignore', 'pipe']
-      }
-    );
-  } catch (error) {
-    console.log(chalk.red('FAILED adding a license'));
-    if (options.debug) {
-      console.log(error);
-    } else {
-      console.log(error.message);
-    }
-  }
-
   Spinner.succeedAndNowDo('Adding elm-review configuration', options.report);
   await Init.createFromTemplate(
     options,

new-package/maintenance/MAINTENANCE.md

@@ -35,15 +35,24 @@ git add --all
 git commit --message="Initialize project"
 ```
 
-### 3. Replace REPLACEME
+### 3. Add a license file
+
+I recommend using the `license` npm tool to generate one.
+You should choose the same license as in your `elm.json` file.
+
+```bash
+npx license
+```
+
+### 4. Replace REPLACEME
 
 In some of the files, notably `elm.json`, `README.md` and the rule files that were created for you, you will find a few `REPLACEME`. You will need to replace all of these and by things that make sense in their individual context.
 
 Again, you can do this step at a later time if you prefer, but you will have to do these before publishing. You will be reminded to do this when running the tests.
 
 Note that you will also have to supply the `summary` field in the `elm.json`, which should be close to the same thing that you will write in the README.
 
-### 4. (Can be done later) Create the project on GitHub
+### 5. (Can be done later) Create the project on GitHub
 
 You can do this step at a later time if you prefer.
 When you do, consider to

test/run-snapshots/elm-review-something-for-new-rule/LICENSE

@@ -35,15 +35,24 @@ git add --all
 git commit --message="Initialize project"
 ```
 
-### 3. Replace REPLACEME
+### 3. Add a license file
+
+I recommend using the `license` npm tool to generate one.
+You should choose the same license as in your `elm.json` file.
+
+```bash
+npx license
+```
+
+### 4. Replace REPLACEME
 
 In some of the files, notably `elm.json`, `README.md` and the rule files that were created for you, you will find a few `REPLACEME`. You will need to replace all of these and by things that make sense in their individual context.
 
 Again, you can do this step at a later time if you prefer, but you will have to do these before publishing. You will be reminded to do this when running the tests.
 
 Note that you will also have to supply the `summary` field in the `elm.json`, which should be close to the same thing that you will write in the README.
 
-### 4. (Can be done later) Create the project on GitHub
+### 5. (Can be done later) Create the project on GitHub
 
 You can do this step at a later time if you prefer.
 When you do, consider to

test/run-snapshots/elm-review-something-for-new-rule/maintenance/MAINTENANCE.md

@@ -25,6 +25,5 @@
     "fs-extra": "^9.0.0",
     "npm-run-all": "^4.1.5",
     "tinyglobby": "^0.2.10"
-  },
-  "license": "BSD-3-Clause"
+  }
 }

test/run-snapshots/elm-review-something-for-new-rule/package.json

@@ -35,15 +35,24 @@ git add --all
 git commit --message="Initialize project"
 ```
 
-### 3. Replace REPLACEME
+### 3. Add a license file
+
+I recommend using the `license` npm tool to generate one.
+You should choose the same license as in your `elm.json` file.
+
+```bash
+npx license
+```
+
+### 4. Replace REPLACEME
 
 In some of the files, notably `elm.json`, `README.md` and the rule files that were created for you, you will find a few `REPLACEME`. You will need to replace all of these and by things that make sense in their individual context.
 
 Again, you can do this step at a later time if you prefer, but you will have to do these before publishing. You will be reminded to do this when running the tests.
 
 Note that you will also have to supply the `summary` field in the `elm.json`, which should be close to the same thing that you will write in the README.
 
-### 4. (Can be done later) Create the project on GitHub
+### 5. (Can be done later) Create the project on GitHub
 
 You can do this step at a later time if you prefer.
 When you do, consider to

test/run-snapshots/elm-review-something/LICENSE

@@ -25,6 +25,5 @@
     "fs-extra": "^9.0.0",
     "npm-run-all": "^4.1.5",
     "tinyglobby": "^0.2.10"
-  },
-  "license": "BSD-3-Clause"
+  }
 }