Skip to content

Parameter handling is inconsistent #114

Description

@Tillaert

Currently, parameters that are objects are not encoded as strings, however, arrays are.

Object parameter: https://github.com/hyperledger/firefly-fabconnect/blob/main/internal/rest/utils/params_test.go#L91
Array parameter: https://github.com/hyperledger/firefly-fabconnect/blob/main/internal/rest/utils/params_test.go#L306

This is not consistent, and begs the question how to pass objects with nested arrays and arrays of objects.

Tests are missing for objectArray.

Firefly is sending objects encoded as strings, and this results in errors, see:

hyperledger-firefly/firefly#1307

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions