Skip to content

Commit 53e8bd1

Browse files
authored
fix: Fix height of source select RHS menu (#2419)
## Summary This PR ensures the height of the RHS kebab menu on the source select component matches the height of the source select input. ### Screenshots or video Before: <img width="330" height="98" alt="Screenshot 2026-06-04 at 1 25 37 PM" src="https://github.com/user-attachments/assets/da02d64e-ba3e-4445-b255-37915102ca3c" /> After: <img width="346" height="78" alt="Screenshot 2026-06-04 at 1 31 20 PM" src="https://github.com/user-attachments/assets/8cef7357-3c49-4036-8810-88c68f89a095" /> <img width="332" height="98" alt="Screenshot 2026-06-04 at 1 31 14 PM" src="https://github.com/user-attachments/assets/c25d5b99-6dc6-4c5a-a126-d680b5fee5b6" /> ### How to test on Vercel preview This can be tested on the preview, wherever the source select is available. ### References - Linear Issue: - Related PRs:
1 parent 8164492 commit 53e8bd1

3 files changed

Lines changed: 13 additions & 6 deletions

File tree

.changeset/smooth-turkeys-dream.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@hyperdx/app": patch
3+
---
4+
5+
fix: Fix height of source select RHS menu

packages/app/src/components/SourceSelect.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ interface SourceManagementMenuProps {
4646
*/
4747
onManageSources?: () => void;
4848
onCreate?: () => void;
49+
size?: string;
4950
}
5051

5152
/**
@@ -63,6 +64,7 @@ interface SourceManagementMenuProps {
6364
*/
6465
export const SourceManagementMenu = ({
6566
hasSelection,
67+
size = 'sm',
6668
onSchemaPreview,
6769
isSchemaPreviewEnabled = true,
6870
onEdit,
@@ -133,7 +135,7 @@ export const SourceManagementMenu = ({
133135
<ActionIcon
134136
variant="subtle"
135137
color="gray"
136-
size="input-xs"
138+
size={`input-${size}`}
137139
className={styles.sourceMenuButton}
138140
data-testid="source-actions-menu"
139141
aria-label="Source actions"
@@ -236,6 +238,7 @@ function SourceSelectControlledComponent({
236238
{hasMenu && (
237239
<SourceManagementMenu
238240
hasSelection={hasSelection}
241+
size={size}
239242
onSchemaPreview={onSchemaPreview}
240243
isSchemaPreviewEnabled={isSchemaPreviewEnabled}
241244
onEdit={onEdit}

packages/app/styles/SourceSelectControlled.module.scss

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,13 @@
4646
border-bottom-left-radius: var(--mantine-radius-default);
4747
}
4848

49-
/* Square only the left edge of the kebab. Fixed 30px height matches the
50-
* input chip; -1px margin overlaps the input's right edge so the shared
51-
* border is one pixel wide, not two. */
49+
/* Square only the left edge of the kebab. The ActionIcon's `input-*`
50+
* size (driven by the adjacent Select's `size`) makes it square and
51+
* matches the input chip's height; -1px margin overlaps the input's
52+
* right edge so the shared border is one pixel wide, not two. */
5253
.sourceMenuButton {
5354
--ai-radius: 0;
5455

55-
width: 30px;
56-
height: 30px;
5756
margin-left: -1px;
5857
background-color: var(--color-bg-field-addon);
5958
border: 1px solid var(--input-bd, var(--color-border));

0 commit comments

Comments
 (0)