refactor(dfir_lang): remove stratum from chain, chain_first_n

PR: #2967

Author: MingweiSamuel

dfir_lang/src/graph/ops/chain.rs

@@ -1,7 +1,5 @@
-use crate::graph::PortIndexValue;
-
 use super::{
-    DelayType, OperatorCategory, OperatorConstraints, RANGE_0, RANGE_1
+    OperatorCategory, OperatorConstraints, RANGE_0, RANGE_1
 };
 
 /// > 2 input streams of the same type, 1 output stream of the same type
@@ -32,11 +30,6 @@ pub const CHAIN: OperatorConstraints = OperatorConstraints {
     flo_type: None,
     ports_inn: None,
     ports_out: None,
-    input_delaytype_fn: |idx| match idx {
-        PortIndexValue::Int(idx) if idx.value == 0 => {
-            Some(DelayType::Stratum)
-        }
-        _else => None,
-    },
+    input_delaytype_fn: |_| None,
     write_fn: super::union::UNION.write_fn,
 };

dfir_lang/src/graph/ops/chain_first_n.rs

@@ -1,11 +1,10 @@
 use quote::quote_spanned;
 
 use crate::graph::{
-    PortIndexValue,
     ops::{OperatorWriteOutput, WriteContextArgs},
 };
 
-use super::{DelayType, OperatorCategory, OperatorConstraints, RANGE_0, RANGE_1};
+use super::{OperatorCategory, OperatorConstraints, RANGE_0, RANGE_1};
 
 /// > 2 input streams of the same type, 1 output stream of the same type
 ///
@@ -36,13 +35,7 @@ pub const CHAIN_FIRST_N: OperatorConstraints = OperatorConstraints {
     flo_type: None,
     ports_inn: None,
     ports_out: None,
-    input_delaytype_fn: |idx| match idx {
-        PortIndexValue::Int(idx) if idx.value == 0 => {
-            // will no longer be needed once subgraphs are always DAGs (only run once per tick)
-            Some(DelayType::Stratum)
-        }
-        _else => None,
-    },
+    input_delaytype_fn: |_| None,
     write_fn: |wc @ &WriteContextArgs {
                    root,
                    op_span,

hydro_test/src/cluster/snapshots/compute_pi_ir@surface_graph_loc2v1.snap

@@ -21,7 +21,6 @@ _16v1 = cross_singleton ();
 _17v1 = map (stageleft :: runtime_support :: fn1_type_hint :: < ((u64 , u64) , bool) , (u64 , u64) > ({ use hydro_lang :: __staged :: __deps :: * ; use hydro_lang :: __staged :: live_collections :: optional :: * ; hydro_lang :: __stageleft_quote_src_live_collections_optional_rs_1103_51 ! ([] [| (d , _) | d]) }));
 _18v1 = for_each (stageleft :: runtime_support :: fnmut1_type_hint :: < (u64 , u64) , () > ({ use crate :: __staged :: __deps :: * ; use crate :: __staged :: cluster :: compute_pi :: * ; # [allow (unused_imports)] use crate :: * ; __stageleft_quote_src_cluster_compute_pi_rs_50_21 ! ([] [| (inside , total) | { println ! ("pi: {} ({} trials)" , 4.0 * inside as f64 / total as f64 , total) ; }]) }));
 _19v1 = handoff();
-_20v1 = handoff();
 
 _1v1 -> _2v1;
 _2v1 -> _3v1;
@@ -32,13 +31,12 @@ _7v1 -> _8v1;
 _8v1 -> _9v1;
 _9v1 -> _10v1;
 _11v1 -> _12v1;
-_10v1 -> _19v1;
+_10v1 -> [0]_13v1;
 _12v1 -> [1]_13v1;
 _13v1 -> _14v1;
 _14v1 -> _15v1;
 _4v1 -> [input]_16v1;
-_15v1 -> _20v1;
+_15v1 -> _19v1;
 _16v1 -> _17v1;
 _17v1 -> _18v1;
-_19v1 -> [0]_13v1;
-_20v1 -> [single]_16v1;
+_19v1 -> [single]_16v1;

hydro_test/src/cluster/snapshots/paxos_ir@acceptor_mermaid.snap

@@ -67,7 +67,7 @@ linkStyle default stroke:#aaa
 6v1-->7v1
 7v1-->8v1
 9v1-->10v1
-8v1--x|0|11v1; linkStyle 7 stroke:red
+8v1-->|0|11v1
 10v1-->|1|11v1
 11v1-->12v1
 6v1-->|input|13v1
@@ -88,12 +88,12 @@ linkStyle default stroke:#aaa
 52v1-->26v1
 26v1-->27v1
 28v1-->29v1
-27v1--x|0|30v1; linkStyle 28 stroke:red
+27v1-->|0|30v1
 29v1-->|1|30v1
 21v1-->|input|31v1
 12v1--x|single|31v1; linkStyle 31 stroke:red
 31v1-->32v1
-34v1--x|0|33v1; linkStyle 33 stroke:red
+34v1-->|0|33v1
 32v1-->34v1
 35v1-->|1|33v1
 26v1-->35v1
@@ -116,8 +116,8 @@ linkStyle default stroke:#aaa
 50v1-->51v1
 51v1-->52v1
 2v1
-34v1
 35v1
+34v1
 16v1
 17v1
 24v1

hydro_test/src/cluster/snapshots/paxos_ir@proposer_mermaid.snap

@@ -274,18 +274,18 @@ linkStyle default stroke:#aaa
 264v1["<div style=text-align:center>(264v1)</div> <code><br>map(|(id, data)| {<br>    (<br>        id.into_tagless(),<br>        hydro_lang::runtime_support::bincode::serialize(&amp;data).unwrap().into(),<br>    )<br>})</code>"]:::otherClass
 265v1["<div style=text-align:center>(265v1)</div> <code><br>dest_sink(DUMMY_SINK)</code>"]:::otherClass
 1v1-->2v1
-132v1--x|0|3v1; linkStyle 1 stroke:red
+132v1-->|0|3v1
 250v1-->|1|3v1
-3v1--x|0|4v1; linkStyle 3 stroke:red
+3v1-->|0|4v1
 50v1-->|1|4v1
 4v1-->5v1
 6v1-->7v1
-5v1--x|0|8v1; linkStyle 7 stroke:red
+5v1-->|0|8v1
 7v1-->|1|8v1
 8v1-->9v1
 17v1--o10v1; linkStyle 10 stroke:red
 11v1-->12v1
-10v1--x|0|13v1; linkStyle 12 stroke:red
+10v1-->|0|13v1
 12v1-->|1|13v1
 9v1-->|input|14v1
 13v1--x|single|14v1; linkStyle 15 stroke:red
@@ -310,7 +310,7 @@ linkStyle default stroke:#aaa
 33v1-->34v1
 34v1-->35v1
 36v1-->37v1
-35v1--x|0|38v1; linkStyle 37 stroke:red
+35v1-->|0|38v1
 37v1-->|1|38v1
 38v1-->39v1
 39v1-->40v1
@@ -340,7 +340,7 @@ linkStyle default stroke:#aaa
 62v1-->63v1
 63v1-->64v1
 65v1-->66v1
-64v1--x|0|67v1; linkStyle 67 stroke:red
+64v1-->|0|67v1
 66v1-->|1|67v1
 67v1-->68v1
 69v1-->70v1
@@ -349,7 +349,7 @@ linkStyle default stroke:#aaa
 72v1-->73v1
 73v1-->74v1
 75v1-->76v1
-74v1--x|0|77v1; linkStyle 76 stroke:red
+74v1-->|0|77v1
 76v1-->|1|77v1
 77v1-->78v1
 68v1-->|input|79v1
@@ -368,7 +368,7 @@ linkStyle default stroke:#aaa
 89v1-->90v1
 90v1-->91v1
 91v1-->92v1
-51v1--x|0|93v1; linkStyle 95 stroke:red
+51v1-->|0|93v1
 92v1-->|1|93v1
 93v1-->94v1
 94v1-->95v1
@@ -402,7 +402,7 @@ linkStyle default stroke:#aaa
 117v1-->118v1
 118v1-->119v1
 120v1-->121v1
-119v1--x|0|122v1; linkStyle 129 stroke:red
+119v1-->|0|122v1
 121v1-->|1|122v1
 122v1-->123v1
 9v1-->|input|124v1
@@ -426,7 +426,7 @@ linkStyle default stroke:#aaa
 140v1-->141v1
 141v1-->142v1
 143v1-->144v1
-142v1--x|0|145v1; linkStyle 153 stroke:red
+142v1-->|0|145v1
 144v1-->|1|145v1
 145v1-->146v1
 128v1-->|input|147v1
@@ -461,9 +461,9 @@ linkStyle default stroke:#aaa
 172v1-->173v1
 186v1--o174v1; linkStyle 186 stroke:red
 175v1-->176v1
-174v1--x|0|177v1; linkStyle 188 stroke:red
+174v1-->|0|177v1
 176v1-->|1|177v1
-173v1--x|0|178v1; linkStyle 190 stroke:red
+173v1-->|0|178v1
 177v1-->|1|178v1
 178v1-->179v1
 162v1-->|input|180v1
@@ -489,7 +489,7 @@ linkStyle default stroke:#aaa
 196v1-->197v1
 197v1-->198v1
 199v1-->200v1
-198v1--x|0|201v1; linkStyle 216 stroke:red
+198v1-->|0|201v1
 200v1-->|1|201v1
 201v1-->202v1
 195v1-->|input|203v1
@@ -504,9 +504,9 @@ linkStyle default stroke:#aaa
 208v1-->|input|209v1
 25v1--x|single|209v1; linkStyle 229 stroke:red
 209v1-->210v1
-204v1--x|0|211v1; linkStyle 231 stroke:red
+204v1-->|0|211v1
 210v1-->|1|211v1
-194v1--x|0|212v1; linkStyle 233 stroke:red
+194v1-->|0|212v1
 211v1-->|1|212v1
 128v1-->213v1
 212v1-->|input|214v1
@@ -521,7 +521,7 @@ linkStyle default stroke:#aaa
 221v1-->222v1
 222v1-->223v1
 223v1-->224v1
-187v1--x|0|225v1; linkStyle 248 stroke:red
+187v1-->|0|225v1
 224v1-->|1|225v1
 225v1-->226v1
 226v1-->227v1
@@ -538,7 +538,7 @@ linkStyle default stroke:#aaa
 231v1--x|neg|236v1; linkStyle 262 stroke:red
 236v1-->237v1
 247v1--o238v1; linkStyle 264 stroke:red
-238v1--x|0|239v1; linkStyle 265 stroke:red
+238v1-->|0|239v1
 216v1-->|1|239v1
 239v1-->240v1
 237v1--o241v1; linkStyle 268 stroke:red

hydro_test/src/cluster/snapshots/two_pc_ir@coordinator_mermaid.snap

@@ -76,7 +76,7 @@ linkStyle default stroke:#aaa
 13v1-->14v1
 14v1-->15v1
 15v1-->16v1
-1v1--x|0|17v1; linkStyle 14 stroke:red
+1v1-->|0|17v1
 16v1-->|1|17v1
 17v1-->18v1
 18v1-->19v1
@@ -102,7 +102,7 @@ linkStyle default stroke:#aaa
 39v1-->40v1
 40v1-->41v1
 41v1-->42v1
-29v1--x|0|43v1; linkStyle 40 stroke:red
+29v1-->|0|43v1
 42v1-->|1|43v1
 43v1-->44v1
 44v1-->45v1
@@ -117,14 +117,14 @@ linkStyle default stroke:#aaa
 53v1-->54v1
 55v1-->56v1
 48v1-->55v1
+28v1
 10v1
 11v1
-28v1
-36v1
-37v1
 54v1
 55v1
 56v1
+36v1
+37v1
 subgraph var_cycle_2 ["var <tt>cycle_2</tt>"]
     style var_cycle_2 fill:transparent
     24v1