Merge pull request #2383 from hermit-os/single_use_lifetimes

fix: single_use_lifetimes

Author: mkroening

Cargo.toml

@@ -399,6 +399,7 @@ rust_2018_idioms = "warn"
 
 # Lints
 redundant_imports = "warn"
+single_use_lifetimes = "warn"
 unexpected_cfgs = { level = "warn", check-cfg = ['cfg(careful)'] }
 unsafe_op_in_unsafe_fn = "warn"
 unused_qualifications = "warn"

src/arch/x86_64/mm/paging.rs

@@ -604,7 +604,7 @@ pub mod mapped_page_table_iter {
 		}
 	}
 
-	impl<'a, P: PageTableFrameMapping> Iterator for MappedPageTableRangeInclusiveIter<'a, P> {
+	impl<P: PageTableFrameMapping> Iterator for MappedPageTableRangeInclusiveIter<'_, P> {
 		type Item = MappedPageRangeInclusiveItem;
 
 		fn next(&mut self) -> Option<Self::Item> {
@@ -753,7 +753,7 @@ pub mod mapped_page_table_iter {
 		}
 	}
 
-	impl<'a, P: PageTableFrameMapping> MappedPageTableIter<'a, P> {
+	impl<P: PageTableFrameMapping> MappedPageTableIter<'_, P> {
 		fn p4_index(&self) -> Option<PageTableIndex> {
 			if self.p4_index >= 512 {
 				return None;
@@ -918,7 +918,7 @@ pub mod mapped_page_table_iter {
 		}
 	}
 
-	impl<'a, P: PageTableFrameMapping> Iterator for MappedPageTableIter<'a, P> {
+	impl<P: PageTableFrameMapping> Iterator for MappedPageTableIter<'_, P> {
 		type Item = MappedPageItem;
 
 		fn next(&mut self) -> Option<Self::Item> {

src/drivers/net/gem.rs

@@ -449,7 +449,7 @@ impl smoltcp::phy::Device for GEMDriver {
 	}
 }
 
-impl<'a> smoltcp::phy::RxToken for RxToken<'a> {
+impl smoltcp::phy::RxToken for RxToken<'_> {
 	fn consume<R, F>(mut self, f: F) -> R
 	where
 		F: FnOnce(&[u8]) -> R,
@@ -483,7 +483,7 @@ impl Drop for RxToken<'_> {
 	}
 }
 
-impl<'a> smoltcp::phy::TxToken for TxToken<'a> {
+impl smoltcp::phy::TxToken for TxToken<'_> {
 	fn consume<R, F>(self, len: usize, f: F) -> R
 	where
 		F: FnOnce(&mut [u8]) -> R,

src/drivers/net/rtl8139.rs

@@ -491,7 +491,7 @@ pub struct RxToken<'a> {
 	rx_fields: &'a mut RxFields,
 }
 
-impl<'a> smoltcp::phy::RxToken for RxToken<'a> {
+impl smoltcp::phy::RxToken for RxToken<'_> {
 	fn consume<R, F>(mut self, f: F) -> R
 	where
 		F: FnOnce(&[u8]) -> R,
@@ -540,7 +540,7 @@ impl Drop for TxToken<'_> {
 	}
 }
 
-impl<'a> smoltcp::phy::TxToken for TxToken<'a> {
+impl smoltcp::phy::TxToken for TxToken<'_> {
 	fn consume<R, F>(self, len: usize, f: F) -> R
 	where
 		F: FnOnce(&mut [u8]) -> R,

src/syscalls/mod.rs

@@ -775,7 +775,7 @@ mod dirent_display {
 		}
 	}
 
-	impl<'a> fmt::Debug for Dirent64Display<'a> {
+	impl fmt::Debug for Dirent64Display<'_> {
 		fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 			let cstr = unsafe { CStr::from_ptr((&raw const self.dirent.d_name).cast::<c_char>()) };