fix(service): exec python so supervise can restart it (#273)

* fix(service): exec python so supervise can restart it

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(service): make the log run script POSIX-sh safe as well

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* docs: correct the rationale for replacing BASH_SOURCE

On Venus OS /bin/sh is bash, so the original line worked. The change is
portability hardening for a script that declares #!/bin/sh, not a bug fix.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: dsteinkopf

service/log/run

@@ -1,8 +1,10 @@
 #!/bin/sh
 exec 2>&1
 #Script Directory
-SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
-SCRIPT_DIR=$(realpath $SCRIPT_DIR/../../)
-SERVICE_NAME=$(basename $SCRIPT_DIR)
+# BASH_SOURCE and &> are bash-only in a #!/bin/sh script; they work today only
+# because /bin/sh is bash on Venus OS.
+SCRIPT_DIR=$(cd "$(dirname "$0")" && pwd)
+SCRIPT_DIR=$(realpath "$SCRIPT_DIR/../../")
+SERVICE_NAME=$(basename "$SCRIPT_DIR")
 # documentation on how to use multilog https://manpages.debian.org/stretch/daemontools/multilog.8.en.html
-exec multilog t s153600 n2 /var/log/${SERVICE_NAME}
+exec multilog t s153600 n2 "/var/log/${SERVICE_NAME}"

service/run

@@ -1,12 +1,16 @@
 #!/bin/sh
 #Script Directory
-SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
+# BASH_SOURCE and &> are bash-only in a #!/bin/sh script; they work today only
+# because /bin/sh is bash on Venus OS.
+SCRIPT_DIR=$(cd "$(dirname "$0")" && pwd)
 #Define the version filename
-CODE_VERSION_FILE=$(realpath $SCRIPT_DIR/../version.txt)
+CODE_VERSION_FILE=$(realpath "$SCRIPT_DIR/../version.txt")
 exec 2>&1
 #Check if the file exists
 if [ -f "$CODE_VERSION_FILE" ]; then
     #If the file exists, print its contents to stdout
     cat "$CODE_VERSION_FILE"
 fi
-python $(realpath $SCRIPT_DIR/../dbus_opendtu.py)
+# exec so supervise watches python itself: otherwise a restart orphans python,
+# it keeps the D-Bus names, and the new process dies with "Bus name already exists".
+exec python "$(realpath "$SCRIPT_DIR/../dbus_opendtu.py")"