Un-inline Mapping.getCondensed and maybe other things as well

[gene-pavlovsky]

I've just noticed that a simple for (key in someMapping.keys()) ... generates over 2 kb of code.
The reason being that Mapping's getCondensed is declared as inline.

I've looked at List and it uses inline sparingly (even there, exists and count can be considered for un-inlining).
However in Mapping, basically every function is inlined, getCondensed seeming to me the most egregious abuse of inline.

Was there any benchmarking or real-world code profiling done on these data structures, to determine what deserves to be inlined, and what doesn't? If not, I propose to remove inline from everything over 1-3 lines of code.

[back2dos]

It's mostly inline because the call site knows the concrete type parameters, which is required to make a condensed map (because of the whole @:multiType weirdness).

[gene-pavlovsky]

So this can't be changed?

[back2dos]

Short of a proper implementation, probably not. It may also be possible to work out something using @:multiType on Mapping.