Skip to content

Commit 08725c8

Browse files
committed
fixed non existant fields conditional statements for assignReviewers
1 parent 3422081 commit 08725c8

1 file changed

Lines changed: 6 additions & 9 deletions

File tree

middlewares/hacker.middleware.js

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -766,8 +766,10 @@ async function assignReviewers(req, res, next) {
766766
// find all hackers created before the cutoff date
767767
const hackers = await hackerModel.find({
768768
$or: [
769-
{ reviewerStatus: HACKER_REVIEWER_STATUS_NONE },
770-
{ reviewerStatus2: HACKER_REVIEWER_STATUS_NONE }
769+
{ reviewerStatus: 'None' },
770+
{ reviewerStatus2: 'None' },
771+
{ reviewerStatus: { $exists: false } },
772+
{ reviewerStatus2: { $exists: false } }
771773
],
772774
_id: { $lte: cutoffObjectId }
773775
}).select('_id reviewerStatus reviewerStatus2 accountId');
@@ -802,24 +804,19 @@ async function assignReviewers(req, res, next) {
802804
const assignedReviewer1 = REVIEWER_NAMES[hackerIndex % revwiewerCount];
803805
const assignedReviewer2 = REVIEWER_NAMES[(hackerIndex + 1) % revwiewerCount];
804806

805-
806-
console.log(`Hacker ${hacker.accountId} - Current Statuses: reviewerStatus=${hacker.reviewerStatus}, reviewerStatus2=${hacker.reviewerStatus2}`);
807-
if (hacker.reviewerStatus !== HACKER_REVIEWER_STATUS_NONE) {
808-
console.log(`Assigning reviewer2 ${assignedReviewer2} to hacker ${hacker.accountId}`);
807+
if (hacker.reviewerStatus !== HACKER_REVIEWER_STATUS_NONE && ("reviewerStatus" in hacker)) {
809808
assignments.push({ hackerId: hacker._id, reviewer2: assignedReviewer2 });
810809

811810
updatePromises.push(
812811
Services.Hacker.updateOne(hacker._id, { reviewerName2: assignedReviewer2 })
813812
);
814-
} else if (hacker.reviewerStatus2 !== HACKER_REVIEWER_STATUS_NONE) {
815-
console.log(`Assigning reviewer1 ${assignedReviewer1} to hacker ${hacker.accountId}`);
813+
} else if (hacker.reviewerStatus2 !== HACKER_REVIEWER_STATUS_NONE && ("reviewerStatus2" in hacker)) {
816814
assignments.push({ hackerId: hacker._id, reviewer: assignedReviewer1 });
817815

818816
updatePromises.push(
819817
Services.Hacker.updateOne(hacker._id, { reviewerName: assignedReviewer1 })
820818
);
821819
} else {
822-
console.log(`Assigning reviewer1 ${assignedReviewer1} and reviewer2 ${assignedReviewer2} to hacker ${hacker.accountId} to hacker ${hacker.accountId}`);
823820
assignments.push({ hackerId: hacker._id, reviewer: assignedReviewer1, reviewer2: assignedReviewer2 });
824821

825822
updatePromises.push(

0 commit comments

Comments
 (0)