test(opentelemetry): add tests for callEnded/streamClosed guards and finished call timing

Author: AgraVator

opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryMetricsModuleTest.java

@@ -2734,6 +2734,54 @@ public void clientAttemptDelayDuration_withOptionalLabels() {
     }
   }
 
+  @Test
+  public void callEnded_beforeAttemptEnded_recordsFinishedCall() {
+    System.setProperty("GRPC_EXPERIMENTAL_ENABLE_DELAY_OBSERVABILITY", "true");
+    try {
+      String target = "target:///";
+      OpenTelemetryMetricsResource resource = GrpcOpenTelemetry.createMetricInstruments(testMeter,
+          enabledMetricsMap, disableDefaultMetrics);
+      OpenTelemetryMetricsModule module = new OpenTelemetryMetricsModule(
+          fakeClock.getStopwatchSupplier(),
+          resource,
+          emptyList(),
+          emptyList());
+
+      CallAttemptsTracerFactory callAttemptsTracerFactory =
+          new CallAttemptsTracerFactory(module, target, CALL_OPTIONS, method.getFullMethodName(),
+              emptyList(), Context.root());
+      ClientStreamTracer tracer = callAttemptsTracerFactory.newClientStreamTracer(
+          ClientStreamTracer.StreamInfo.newBuilder().build(), new Metadata());
+
+      callAttemptsTracerFactory.callEnded(Status.OK, CALL_OPTIONS);
+      callAttemptsTracerFactory.attemptEnded(CALL_OPTIONS);
+
+      assertNotNull(tracer);
+    } finally {
+      System.clearProperty("GRPC_EXPERIMENTAL_ENABLE_DELAY_OBSERVABILITY");
+    }
+  }
+
+  @Test
+  public void serverStreamClosed_calledTwice_secondCallNoOp() {
+    OpenTelemetryMetricsResource resource = GrpcOpenTelemetry.createMetricInstruments(testMeter,
+        enabledMetricsMap, disableDefaultMetrics);
+    OpenTelemetryMetricsModule module = new OpenTelemetryMetricsModule(
+        fakeClock.getStopwatchSupplier(),
+        resource,
+        emptyList(),
+        emptyList());
+
+    ServerStreamTracer.Factory serverTracerFactory = module.getServerTracerFactory();
+    ServerStreamTracer serverTracer =
+        serverTracerFactory.newServerStreamTracer(method.getFullMethodName(), new Metadata());
+
+    serverTracer.streamClosed(Status.OK);
+    serverTracer.streamClosed(Status.CANCELLED);
+
+    assertNotNull(serverTracer);
+  }
+
   private static List<MetricData> sortByName(List<MetricData> metrics) {
     metrics.sort((m1, m2) -> m1.getName().compareTo(m2.getName()));
     return metrics;

opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryTracingModuleTest.java

@@ -883,6 +883,57 @@ public void clientCallDelayStart_delayTypeTransition_closesPreviousSpan() {
     assertEquals(2L, callDelaySpanCount);
   }
 
+  @Test
+  public void clientCallEnded_calledTwice_secondCallNoOp() {
+    OpenTelemetryTracingModule tracingModule = new OpenTelemetryTracingModule(
+        openTelemetryRule.getOpenTelemetry());
+    Span clientSpan = tracerRule.spanBuilder("test-client-span").startSpan();
+    CallAttemptsTracerFactory callTracer =
+        tracingModule.newClientCallTracer(clientSpan, method);
+
+    callTracer.callEnded(Status.OK);
+    callTracer.callEnded(Status.CANCELLED);
+    clientSpan.end();
+
+    List<SpanData> spans = openTelemetryRule.getSpans();
+    assertNotNull(spans);
+  }
+
+  @Test
+  public void clientStreamClosed_calledTwice_secondCallNoOp() {
+    OpenTelemetryTracingModule tracingModule = new OpenTelemetryTracingModule(
+        openTelemetryRule.getOpenTelemetry());
+    Span clientSpan = tracerRule.spanBuilder("test-client-span").startSpan();
+    CallAttemptsTracerFactory callTracer =
+        tracingModule.newClientCallTracer(clientSpan, method);
+    ClientStreamTracer clientStreamTracer =
+        callTracer.newClientStreamTracer(STREAM_INFO, new Metadata());
+
+    clientStreamTracer.streamClosed(Status.OK);
+    clientStreamTracer.streamClosed(Status.CANCELLED);
+    callTracer.callEnded(Status.OK);
+    clientSpan.end();
+
+    List<SpanData> spans = openTelemetryRule.getSpans();
+    assertNotNull(spans);
+  }
+
+  @Test
+  public void serverStreamClosed_calledTwice_secondCallNoOp() {
+    OpenTelemetryTracingModule tracingModule = new OpenTelemetryTracingModule(
+        openTelemetryRule.getOpenTelemetry());
+    ServerStreamTracer.Factory serverTracerFactory =
+        tracingModule.getServerTracerFactory();
+    ServerStreamTracer serverTracer =
+        serverTracerFactory.newServerStreamTracer(method.getFullMethodName(), new Metadata());
+
+    serverTracer.streamClosed(Status.OK);
+    serverTracer.streamClosed(Status.CANCELLED);
+
+    List<SpanData> spans = openTelemetryRule.getSpans();
+    assertNotNull(spans);
+  }
+
   @Test
   public void clientInterceptor() {
     testClientInterceptors(false);