fix: prevent method calls on None

Author: grayespinoza

graphicnovelpricescraper/retailers/amazon.py

@@ -35,14 +35,17 @@ async def scrape(self, isbn: str, title: str) -> GraphicNovel:
             price_fraction = await page.locator(
                 "span.a-price-fraction"
             ).first.text_content()
-            price = float(f"{price_whole}{price_fraction}")
+            if price_whole and price_fraction:
+                price_whole = price_whole.strip()
+                price_fraction = price_fraction.strip()
+                price = float(f"{price_whole}{price_fraction}")
 
             href = await page.locator(
                 "div[data-cy='title-recipe'] a"
             ).first.get_attribute("href")
             if href:
                 href = href.strip().split("?", 1)[0]
-            url = f"https://www.amazon.com{href}"
+                url = f"https://www.amazon.com{href}"
         except Exception as e:
             print(f"Unable to scrape {isbn} from Amazon: {e}")
         finally:

graphicnovelpricescraper/retailers/barnesandnoble.py

@@ -32,7 +32,9 @@ async def scrape(self, isbn: str, title: str) -> GraphicNovel:
             price_text = await page.locator(
                 ".product-item-card__current-price"
             ).first.text_content()
-            price = float(price_text.replace("$", "").strip())
+            if price_text:
+                price_text = price_text.strip()
+                price = float(price_text.replace("$", ""))
 
             href = (
                 await page.locator(".product-item-card__title")
@@ -41,7 +43,7 @@ async def scrape(self, isbn: str, title: str) -> GraphicNovel:
             )
             if href:
                 href = href.strip().split("?", 1)[0]
-            url = f"https://www.barnesandnoble.com{href}"
+                url = f"https://www.barnesandnoble.com{href}"
         except Exception as e:
             print(f"Unable to scrape {isbn} from Barnes & Noble: {e}")
         finally:

graphicnovelpricescraper/retailers/cheapgraphicnovels.py

@@ -35,12 +35,14 @@ async def scrape(self, isbn: str, title: str) -> GraphicNovel:
                 title = title.strip()
 
             price_text = await page.locator(".price.product-price").first.text_content()
-            price = float(price_text.replace("$", "").strip())
+            if price_text:
+                price_text = price_text.strip()
+                price = float(price_text.replace("$", ""))
 
             href = await page.locator(".fn.url").first.get_attribute("href")
             if href:
                 href = href.strip().split("?", 1)[0]
-            url = f"https://cheapgraphicnovels.com/{href}"
+                url = f"https://cheapgraphicnovels.com/{href}"
         except Exception as e:
             print(f"Unable to scrape {isbn} from Cheap Graphic Novels: {e}")
         finally:

graphicnovelpricescraper/retailers/instocktrades.py

@@ -44,12 +44,14 @@ async def scrape(self, isbn: str, title: str) -> GraphicNovel:
                 title = await page.locator(".title").first.inner_text()
 
                 price_text = await page.locator(".price").first.inner_text()
-                price = float(price_text.replace("$", "").strip())
+                if price_text:
+                    price_text = price_text.strip()
+                    price = float(price_text.replace("$", ""))
 
                 href = await page.locator(".title a").first.get_attribute("href")
                 if href:
                     href = href.strip().split("?", 1)[0]
-                url = f"https://www.instocktrades.com{href}"
+                    url = f"https://www.instocktrades.com{href}"
             else:
                 title = ""
         except Exception as e:

graphicnovelpricescraper/retailers/organicpricedbooks.py

@@ -34,14 +34,16 @@ async def scrape(self, isbn: str, title: str) -> GraphicNovel:
                 price_text = await page.locator(
                     "span.price-item.price-item--sale.price-item--last"
                 ).first.inner_text()
-                price = float(price_text.replace("$", "").replace("USD", "").strip())
+                if price_text:
+                    price_text = price_text.strip()
+                    price = float(price_text.replace("$", "").replace("USD", ""))
 
                 href = await page.locator("a.full-unstyled-link").first.get_attribute(
                     "href"
                 )
                 if href:
                     href = href.strip().split("?", 1)[0]
-                url = f"https://www.panelboundcomics.com{href}"
+                    url = f"https://www.panelboundcomics.com{href}"
             else:
                 title = ""
         except Exception as e:

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "graphicnovelpricescraper"
-version = "0.1.1"
+version = "0.1.2"
 dependencies = [
   "playwright>=1.60.0"
 ]