Skip to content

Commit 376bd91

Browse files
MoonBoi9001claude
andauthored
docs(dips): align DIPs casing and expansion with GIP-0081 (#1040)
The Direct Indexing Payments feature was named three different ways across docs, comments and log strings — "DIPS" plus two conflicting long-forms — none matching the spec. This settles on the GIP-0081 wording everywhere: "DIPs (Direct Indexing Payments)". Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 8c11e57 commit 376bd91

4 files changed

Lines changed: 12 additions & 12 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ The TAP Agent is an actor-based system powered by [ractor](https://crates.io/cra
240240
| `indexer-allocation` | Shared structs and logic related to subgraph allocations in The Graph. |
241241
| `indexer-attestation` | Provides tools for generating and verifying attestations for requests and responses. |
242242
| `indexer-config` | Parses shared configuration used by both `indexer-service-rs` and `indexer-tap-agent`. |
243-
| `indexer-dips` | (WIP) Library for managing DIPS (Distributed Indexing Payment System). |
243+
| `indexer-dips` | (WIP) Library for managing DIPs (Direct Indexing Payments). |
244244
| `indexer-monitor` | Monitors subgraphs through polling and updates shared state with reactive components. |
245245
| `indexer-query` | Type-safe GraphQL queries, leveraging [graphql-client](https://github.com/graphql-rust/graphql-client). |
246246
| `indexer-service-rs` | Subgraph service application that handles payments, routes queries to graph-node, and creates attestations. |

crates/config/maximal-config-example.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ max_receipts_per_request = 10000
174174
0xDDE4cfFd3D9052A9cb618fC05a1Cd02be1f2F467 = "https://tap-aggregator.network.thegraph.com"
175175
0xDD6a6f76eb36B873C1C184e8b9b9e762FE216490 = "https://tap-aggregator-arbitrum-one.graphops.xyz"
176176

177-
# DIPS (Decentralized Indexing Payment System)
177+
# DIPs (Direct Indexing Payments)
178178
# These fields are consumed by the public `/dips/info` HTTP endpoint. External
179179
# tooling reads them to discover which networks you are willing to index and at
180180
# what minimum price, ahead of any indexing agreement actually being offered.

crates/service/src/constants.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ use std::time::Duration;
3939
/// - Graph-node processing time
4040
pub const HTTP_CLIENT_TIMEOUT: Duration = Duration::from_secs(30);
4141

42-
/// Timeout for DIPS HTTP client requests.
42+
/// Timeout for DIPs HTTP client requests.
4343
///
44-
/// DIPS (Decentralized Indexer Payment System) operations involve:
44+
/// DIPs (Direct Indexing Payments) operations involve:
4545
/// - IPFS content fetching
4646
/// - Agreement validation and storage
4747
/// - Network registry lookups

crates/service/src/service.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ pub async fn run() -> anyhow::Result<()> {
121121
let indexer_address = config.indexer.indexer_address;
122122
let ipfs_url = config.service.ipfs_url.clone();
123123

124-
// V2 escrow accounts (used by DIPS) are in the network subgraph
124+
// V2 escrow accounts (used by DIPs) are in the network subgraph
125125
let escrow_v2_query_url_for_dips = config.subgraphs.network.config.query_url.clone();
126126

127127
let collector_address = config.blockchain.receipts_verifier_address_v2;
@@ -210,18 +210,18 @@ pub async fn run() -> anyhow::Result<()> {
210210

211211
let addr: SocketAddr = format!("{host}:{port}")
212212
.parse()
213-
.with_context(|| format!("Invalid DIPS host:port '{host}:{port}'"))?;
213+
.with_context(|| format!("Invalid DIPs host:port '{host}:{port}'"))?;
214214

215215
let ipfs_fetcher: Arc<dyn IpfsFetcher> = Arc::new(
216216
IpfsClient::new(ipfs_url.as_str())
217217
.with_context(|| format!("Failed to create IPFS client for URL '{ipfs_url}'"))?,
218218
);
219219

220-
// TODO: Try to re-use the same watcher for both DIPS and TAP
220+
// TODO: Try to re-use the same watcher for both DIPs and TAP
221221
let dips_http_client = create_http_client(DIPS_HTTP_CLIENT_TIMEOUT, false)
222-
.context("Failed to create DIPS HTTP client")?;
222+
.context("Failed to create DIPs HTTP client")?;
223223

224-
tracing::info!("DIPS using V2 escrow from network subgraph");
224+
tracing::info!("DIPs using V2 escrow from network subgraph");
225225
let escrow_subgraph_for_dips = Box::leak(Box::new(
226226
SubgraphClient::new(
227227
dips_http_client,
@@ -244,7 +244,7 @@ pub async fn run() -> anyhow::Result<()> {
244244
max_signers_per_payer,
245245
)
246246
.await
247-
.with_context(|| "Failed to create escrow accounts V2 watcher for DIPS")?;
247+
.with_context(|| "Failed to create escrow accounts V2 watcher for DIPs")?;
248248

249249
let registry = NetworksRegistry::from_latest_version()
250250
.await
@@ -268,7 +268,7 @@ pub async fn run() -> anyhow::Result<()> {
268268
chain_id,
269269
};
270270

271-
info!(address = %addr, "Starting DIPS gRPC server");
271+
info!(address = %addr, "Starting DIPs gRPC server");
272272

273273
let dips_shutdown_token = shutdown_token.clone();
274274
tokio::spawn(async move {
@@ -299,7 +299,7 @@ async fn start_dips_server(
299299
.serve_with_shutdown(addr, shutdown)
300300
.await
301301
{
302-
tracing::error!(error = %e, "DIPS gRPC server error");
302+
tracing::error!(error = %e, "DIPs gRPC server error");
303303
}
304304
}
305305

0 commit comments

Comments
 (0)