ci: enforce warnings as errors in test entrypoints#357
Merged
filmil merged 1 commit intoJun 19, 2026
Conversation
Contributor
Author
|
Can I get a review of this? |
Add RUSTFLAGS="-D warnings" to cargo test and cargo doc invocations in both entrypoint.sh and entrypoint-test-current.sh so that any newly introduced compiler warning causes CI to fail. This commit was created by an automated coding assistant, with human supervision.
Contributor
Author
|
@filmil — friendly bump. Three open PRs awaiting review:
All three are mergeable with no conflicts. Let me know if any of them need rework, or if you'd prefer a different merge order. |
Member
Weird, I do not rememebr seeing this nudge. In any case thank you for the nudge. |
filmil
approved these changes
Jun 1, 2026
Member
|
Looking at this now, I rememebr reviewing this, but not approving it. :/ |
clydegerber
force-pushed
the
fix/reinstate_null_ptr_deref_check
branch
from
90f9d6e to
a7763d4
Compare
Contributor
Author
|
@filmil - gentle nudge on merging these open PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RUSTFLAGS="-D warnings"torun_cargo_test()andrun_cargo_doc()inbuild/entrypoint.shAll compiler warnings have been addressed in the preceding PRs (#349, #350, #356). This commit promotes warnings to errors in CI to prevent regressions.
Test plan
-D warningsenabledThis commit was created by an automated coding assistant, with human supervision.