Skip to content

Commit 764b924

Browse files
tyethclaude
andcommitted
build: stop passing literal quotes as package_folder_prefix
circuitpython-build-bundles splits --package_folder_prefix on ", " and matches each entry with str.startswith(). The gawk that builds the list wrapped it in literal double quotes, so the first and last entries came through as '"sensirion_i2c_driver' and 'sensirion_i2c_sen5x"' and matched no folder. Both libraries then fell back to legacy autodetection, which found only the top-level conftest.py, and the bundle shipped one module instead of the drivers. With only two libraries here, both entries carry a stray quote, so every release asset since the tooling moved on has been effectively empty. The same bug is in the upstream community bundle, where it silently drops the first and last library of the ls -U ordering. Also allow build.yml to be started by hand, as there was no way to re-run it without pushing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 5fae462 commit 764b924

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Build CI
22

3-
on: [pull_request, push]
3+
on: [pull_request, push, workflow_dispatch]
44

55
jobs:
66
test:

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ jobs:
3838
echo prefix=$(
3939
ls -RUx |
4040
gawk -F '\n' '{ match($1, /(drivers|helpers)\/(.+)\/(.+)\:/, arr) ; if (length(arr[0]) > 0 && match(arr[3], arr[2]) > 0) printf "%s, ", arr[3] }' |
41-
gawk '{ trimmed = substr($0, 1, length($0) - 2) ; print "\"" trimmed "\"" }'
41+
gawk '{ print substr($0, 1, length($0) - 2) }'
4242
) >> $GITHUB_OUTPUT
4343
- name: Build assets
44-
run: circuitpython-build-bundles --filename_prefix ${{ steps.repo-name.outputs.repo-name }} --library_location libraries --library_depth 2 --package_folder_prefix ${{ steps.pkg-folder.outputs.prefix }}
44+
run: circuitpython-build-bundles --filename_prefix ${{ steps.repo-name.outputs.repo-name }} --library_location libraries --library_depth 2 --package_folder_prefix "${{ steps.pkg-folder.outputs.prefix }}"
4545
- name: Upload Release Assets
4646
uses: shogo82148/actions-upload-release-asset@v1
4747
with:

build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ set -e
2929
P=$(
3030
ls -RUx |
3131
gawk -F '\n' '{ match($1, /(drivers|helpers)\/(.+)\/(.+)\:/, arr) ; if (length(arr[0]) > 0 && match(arr[3], arr[2]) > 0) printf "%s, ", arr[3] }' |
32-
gawk '{ trimmed = substr($0, 1, length($0) - 2) ; print "\"" trimmed "\"" }'
32+
gawk '{ print substr($0, 1, length($0) - 2) }'
3333
)
3434

3535
circuitpython-build-bundles --filename_prefix circuitpython-community-bundle --library_location libraries --library_depth 2 --package_folder_prefix "$P"

0 commit comments

Comments
 (0)