Skip to content

cmd/go: maintain toolchain for godebug default in go mod tidy#79583

Open
amirHdev wants to merge 1 commit into
golang:masterfrom
amirHdev:mod-tidy-godebug-toolchain
Open

cmd/go: maintain toolchain for godebug default in go mod tidy#79583
amirHdev wants to merge 1 commit into
golang:masterfrom
amirHdev:mod-tidy-godebug-toolchain

Conversation

@amirHdev

@amirHdev amirHdev commented May 21, 2026

Copy link
Copy Markdown
Contributor

When godebug default=go1.x implies a newer minimum toolchain than the
go line alone, go mod tidy should preserve a matching toolchain
directive in go.mod.

Without that, tidy can leave go.mod in a state where an older Go
toolchain fails to load the file instead of following the normal
toolchain-switching path.

This change treats godebug default=go1.x as an implicit minimum
toolchain requirement when computing the main module roots for the
tidy rewrite path. It also adds a regression test covering that case.

Fixes #79153

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: d70a073) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/781020.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/781020.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Amirhosein Akhlaghpoor:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/781020.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cmd/go: go mod tidy can automatically maintain toolchain directive when godebug default requires a higher toolchain

2 participants