cmd/go: maintain toolchain for godebug default in go mod tidy#79583
Open
amirHdev wants to merge 1 commit into
Open
cmd/go: maintain toolchain for godebug default in go mod tidy#79583amirHdev wants to merge 1 commit into
amirHdev wants to merge 1 commit into
Conversation
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Contributor
|
This PR (HEAD: d70a073) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/781020. Important tips:
|
Contributor
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/781020. |
Contributor
|
Message from Amirhosein Akhlaghpoor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/781020. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When godebug default=go1.x implies a newer minimum toolchain than the
go line alone, go mod tidy should preserve a matching toolchain
directive in go.mod.
Without that, tidy can leave go.mod in a state where an older Go
toolchain fails to load the file instead of following the normal
toolchain-switching path.
This change treats godebug default=go1.x as an implicit minimum
toolchain requirement when computing the main module roots for the
tidy rewrite path. It also adds a regression test covering that case.
Fixes #79153