chore: clean-up download page

- remove old analytics-label noise and dead code
- fix checksum rendering to be OS-adaptive and updated for Windows
- fix release notes links; moving next to the date

Author: chadlwilson

source/assets/javascripts/app/_download.js

@@ -39,49 +39,42 @@ var showDownloadLinks = (function ($) {
     );
 
     var addURLToFiles = function (release) {
-      var addDetailsFrom = R.curry(function (release, analyticsIDPrefix, o) {
+      var addDetailsFrom = R.curry(function (release, o) {
         var afterAddingURL = R.assoc(
           "url",
           settings.download_prefix + release["go_full_version"] + "/" + o["file"],
           o
         );
-        var afterAddingFilename = R.assoc(
+        return R.assoc(
           "filename",
           R.last(o["file"].split("/")),
           afterAddingURL,
           o
         );
-        var afterAddingAnalyticsID = R.assoc(
-          "analytics_id",
-          analyticsIDPrefix + "_" + release["go_full_version"],
-          afterAddingFilename,
-          o
-        );
-        return afterAddingAnalyticsID;
       });
 
       return R.evolve({
           win: {
-            server: addDetailsFrom(release, "Windows-Server"),
-            agent: addDetailsFrom(release, "Windows-Agent"),
+            server: addDetailsFrom(release),
+            agent: addDetailsFrom(release),
           },
           osx: {
-            server: addDetailsFrom(release, "Mac-Server"),
-            agent: addDetailsFrom(release, "Mac-Agent"),
-            "server-aarch64": addDetailsFrom(release, "Mac-Server-Aarch64"),
-            "agent-aarch64": addDetailsFrom(release, "Mac-Agent-Aarch64")
+            server: addDetailsFrom(release), // only needed for "show older releases" until June 2027
+            agent: addDetailsFrom(release),  // only needed for "show older releases" until June 2027
+            "server-aarch64": addDetailsFrom(release),
+            "agent-aarch64": addDetailsFrom(release)
           },
           deb: {
-            server: addDetailsFrom(release, "LinuxDeb-Server"),
-            agent: addDetailsFrom(release, "LinuxDeb-Agent")
+            server: addDetailsFrom(release),
+            agent: addDetailsFrom(release)
           },
           rpm: {
-            server: addDetailsFrom(release, "LinuxRpm-Server"),
-            agent: addDetailsFrom(release, "LinuxRpm-Agent")
+            server: addDetailsFrom(release),
+            agent: addDetailsFrom(release)
           },
           generic: {
-            server: addDetailsFrom(release, "Package-Server"),
-            agent: addDetailsFrom(release, "Package-Agent")
+            server: addDetailsFrom(release),
+            agent: addDetailsFrom(release)
           }
         },
         release
@@ -99,7 +92,7 @@ var showDownloadLinks = (function ($) {
     var addReleaseDate = R.curry(function (release) {
       return R.assoc(
         "release_date",
-        new Date(release["release_time_readable"]).toDateString().substr(4),
+        new Date(release["release_time_readable"]).toDateString().substring(4),
         release
       );
     });
@@ -229,9 +222,8 @@ var setupShowVerifyChecksumMessage = (function ($) {
       );
       $("#verify-checksum-message").html(
         template({
+          installer_type: checksumElement.data("installer_type"),
           filename: checksumElement.data("filename"),
-          md5sum: checksumElement.data("md5sum"),
-          sha1sum: checksumElement.data("sha1sum"),
           sha256sum: checksumElement.data("sha256sum")
         })
       );
@@ -241,19 +233,9 @@ var setupShowVerifyChecksumMessage = (function ($) {
 })(jQuery);
 
 var determinePackageNameBasedOnOS = function () {
-  var userDefinedPackageName = window.location.hash.substr(1);
-  var validPackageNames = [
-    "zip",
-    "windows",
-    "osx",
-    "debian",
-    "redhat",
-    "docker"
-  ];
-  if (
-    userDefinedPackageName !== "" &&
-    validPackageNames.includes(userDefinedPackageName)
-  ) {
+  var userDefinedPackageName = window.location.hash.substring(1);
+  var validPackageNames = ["zip", "windows", "osx", "debian", "redhat", "docker"];
+  if (userDefinedPackageName !== "" && validPackageNames.includes(userDefinedPackageName)) {
     return userDefinedPackageName;
   }
 
@@ -273,24 +255,13 @@ var switchDownloadType = function (currentInstallerType) {
   $(".release-type input." + currentInstallerType).attr("checked", true);
 };
 
-var showHelpLinksFor = (function ($) {
-  return function (packageName) {
-    var installer_type_to_help_link_type = {
-      debian: "linux",
-      redhat: "linux",
-      windows: "windows",
-      zip: "zip",
-      osx: "osx"
-    };
-    var template = Handlebars.compile($("#downloads-help-links").html());
+Handlebars.registerHelper("in", function (string, substring) {
+  return string.includes(substring);
+});
 
-    $("#help-links").html(
-      template({
-        os: installer_type_to_help_link_type[packageName]
-      })
-    );
-  };
-})(jQuery);
+Handlebars.registerHelper("not_in", function (string, substring) {
+  return !string.includes(substring);
+});
 
 Handlebars.registerHelper("size", function (
   array,
@@ -326,7 +297,6 @@ Handlebars.registerHelper("size", function (
         options.inverse(this);
     default:
       throw "Invalid operator " + operator + ".";
-      break;
   }
 });
 
@@ -353,6 +323,10 @@ function additionalArch(release) {
   return archsFor(release)[1];
 }
 
+Handlebars.registerHelper('json', function (context) {
+  return JSON.stringify(context, null, 2);
+});
+
 Handlebars.registerHelper("primary-arch", primaryArch);
 
 Handlebars.registerHelper("additional-arch", additionalArch);

source/assets/javascripts/app/_main.js

@@ -127,25 +127,6 @@ jQuery(document).ready(function ($) {
     $(".imagemodal").hide();
   });
 
-  // Add smooth scrolling to analytics CTA and support page CTA
-  $(".cta-analytics, .support-banner-cta").on('click', function(event) {
-    var clickedElement = $(this);
-    var anchorOfTargetElement = clickedElement.data('link-target');
-    var offsetToUseForScrolling = parseInt(clickedElement.data('link-target-offset') || "0");
-
-    if (typeof anchorOfTargetElement === "undefined") {
-      return;
-    }
-
-    $('html, body').animate({
-      scrollTop: $(anchorOfTargetElement).offset().top + offsetToUseForScrolling
-    }, 800, function() {
-      history.replaceState(null, null, anchorOfTargetElement);
-    });
-
-    event.preventDefault();
-  });
-
   //why go-cd lightbox
   $('.chocolat-parent').Chocolat();
 

source/assets/stylesheets/scss/_analytics-trial.scss

@@ -173,10 +173,6 @@ body.download {
       }
     }
 
-    .fa {
-      display: none;
-    }
-
     .notes {
       margin: 20px 0;
 
@@ -232,7 +228,6 @@ body.download {
     z-index: 20;
     padding: 30px;
     background: rgba(0, 0, 0, 0.80);
-    left: 0;
 
     @media (min-width: $screen-tablet) {}
 
@@ -255,22 +250,20 @@ body.download {
 
       @media (min-width: $screen-tablet) {
         width: 90%;
-        width: 100%;
         transform: translateY(-50%);
         left: 0;
         top: 50%;
       }
 
       @media (min-width: $screen-desktop) {
         width: 90%;
-        width: 800px;
         transform: translate(-50%, -50%);
         left: 50%;
         top: 50%;
       }
 
       .code {
-        width: 735px;
+        width: 90%;
 
         .commands,
         .prompts,
@@ -286,14 +279,15 @@ body.download {
         .prompts {
           color: #777;
           float: left;
-          width: 14%;
+          width: 10%;
+          height: 100%;
           margin: 10px 0 0 0;
           padding: 10px 10px 0 10px;
         }
 
         .commands {
           float: right;
-          width: 86%;
+          width: 90%;
           margin: 10px 0 0 0;
           padding: 10px 10px 0 10px;
         }

source/assets/stylesheets/scss/_downloads.scss

@@ -41,15 +41,13 @@
 @import "scss/contribute";
 @import "scss/resources";
 @import "scss/releases";
-@import "scss/roadmap";
 @import "scss/innerpages";
 @import "scss/campaign";
 @import "scss/continuousdelivery";
 @import "scss/gocd-demo";
 @import "scss/test-drive-gocd";
 @import "scss/prism.min";
 @import "scss/pipeline_conf";
-@import "scss/analytics-trial";
 @import "scss/analytics-feedback";
 @import "chocolate_override";
 @import "scss/elastic-agents";

source/assets/stylesheets/scss/_roadmap.scss

@@ -41,7 +41,7 @@ show_features: true
         </div>
       </div>
 
-        <%= link_to 'Download for free', "/assets/images/campaign/cd101/ebook-continuous-delivery-101.pdf", {:class => "btn  button-brand cd101-cta", "analytics-label" => "campaign-download-cta"} %>
+        <%= link_to 'Download for free', "/assets/images/campaign/cd101/ebook-continuous-delivery-101.pdf", {:class => "btn  button-brand cd101-cta"} %>
 
     </div>
     <% end %>

source/assets/stylesheets/site.css.scss

@@ -132,7 +132,7 @@ meta_keywords: "GoCD, continuous delivery, continuous delivery software, continu
         <h3>How to start contributing</h3>
         <p>
           Decide how you want to contribute: picking up an <a href="https://github.com/gocd/gocd/issues">outstanding
-          issue</a>, adding a new feature, or building a plugin, etc. Looking for inspiration? Check out <%= link_to 'GoCD\'s Roadmap', '/roadmap/index.html' %> for a view into where the product is heading this year.
+          issue</a>, adding a new feature, or building a plugin, etc.
         </p>
 
         <p>