Skip to content

Commit e20bb8a

Browse files
erquhartclaude
andcommitted
Drop the httpPrefix provider option from the catalog registration examples
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent b32bbd8 commit e20bb8a

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

packages/core/src/oauth/component/github.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,15 @@ export const normalizeGithubProfile: OauthProfile = (
7272
* ```ts
7373
* provider(OauthGithub, {
7474
* component: components.oauthGithub,
75-
* httpPrefix: "/oauth/github",
7675
* allowedRedirectOrigins: ["https://app.example.com"],
7776
* })
7877
* ```
7978
*
8079
* Mount the component under `httpPrefix: "/oauth/github"` in
8180
* convex.config.ts, binding `PROVIDER_NAME: "github"` and GitHub's
8281
* `CLIENT_ID`/`CLIENT_SECRET`, and register
83-
* `<site-url>/oauth/github/callback` as the redirect URI with GitHub.
82+
* `<site-url>/oauth/github/callback` as the redirect URI with GitHub. The
83+
* mount's prefix alone determines the callback URL.
8484
*
8585
* Identity comes from the userinfo endpoints since GitHub returns no id_token.
8686
*/

packages/core/src/oauth/component/google.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,15 @@ export const normalizeGoogleProfile: OauthProfile = (claims) => {
4646
* ```ts
4747
* provider(OauthGoogle, {
4848
* component: components.oauthGoogle,
49-
* httpPrefix: "/oauth/google",
5049
* allowedRedirectOrigins: ["https://app.example.com"],
5150
* })
5251
* ```
5352
*
5453
* Mount the component under `httpPrefix: "/oauth/google"` in
5554
* convex.config.ts, binding `PROVIDER_NAME: "google"` and Google's
5655
* `CLIENT_ID`/`CLIENT_SECRET`, and register
57-
* `<site-url>/oauth/google/callback` as the redirect URI with Google.
56+
* `<site-url>/oauth/google/callback` as the redirect URI with Google. The
57+
* mount's prefix alone determines the callback URL.
5858
*/
5959
export const OauthGoogle = Oauth("google", {
6060
authorizationEndpoint: "https://accounts.google.com/o/oauth2/v2/auth",

packages/core/src/oauth/component/setup.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ const PROTOCOL_PARAMS = [
161161
* }),
162162
* provider(OauthGithub, {
163163
* component: components.oauthGithub,
164-
* httpPrefix: "/oauth/github",
165164
* allowedRedirectOrigins: [...],
166165
* }),
167166
* ]

0 commit comments

Comments
 (0)