Failing tests on develop

[MaxGyver83]

When I run go test ./... on the develop branch, some tests fail:

...
--- FAIL: TestMenuBar (0.59s)
    --- FAIL: TestMenuBar/mouse_control_and_basic_behaviour (0.45s)
        --- FAIL: TestMenuBar/mouse_control_and_basic_behaviour/switch_theme (0.16s)
            --- FAIL: TestMenuBar/mouse_control_and_basic_behaviour/switch_theme/step_2 (0.07s)
                util_helper.go:54: 
                    	Error Trace:	/home/max/repos/my-fyne/internal/test/util_helper.go:54
                    	            				/home/max/repos/my-fyne/test/test_helper.go:78
                    	            				/home/max/repos/my-fyne/internal/driver/glfw/menu_bar_test.go:327
...
FAIL
FAIL	fyne.io/fyne/v2/internal/driver/glfw	14.753s
--- FAIL: Test_canvas_Dragged (0.09s)
    canvas_test.go:94: 
        	Error Trace:	/home/max/repos/my-fyne/internal/driver/mobile/canvas_test.go:94
        	Error:      	Should be true
        	Test:       	Test_canvas_Dragged
    canvas_test.go:95: 
        	Error Trace:	/home/max/repos/my-fyne/internal/driver/mobile/canvas_test.go:95
        	Error:      	Not equal: 
        	            	expected: *widget.Scroll(&widget.Scroll{Base:widget.Base{hidden:false, position:fyne.Position{X:4, Y:4}, size:fyne.Size{Width:32, Height:16}, impl:(*widget.Scroll)(0xc0003b50e0)}, minSize:fyne.Size{Width:0, Height:0}, Direction:0, Content:(*widget.Label)(0xc00022c780), Offset:fyne.Position{X:0, Y:0}, OnScrolled:(func(fyne.Position))(nil)})
        	            	actual  : <nil>(<nil>)
        	Test:       	Test_canvas_Dragged
    canvas_test.go:101: 
        	Error Trace:	/home/max/repos/my-fyne/internal/driver/mobile/canvas_test.go:101
        	Error:      	Should be true
        	Test:       	Test_canvas_Dragged
    canvas_test.go:102: 
        	Error Trace:	/home/max/repos/my-fyne/internal/driver/mobile/canvas_test.go:102
        	Error:      	Not equal: 
        	            	expected: fyne.Position{X:0, Y:5}
        	            	actual  : fyne.Position{X:0, Y:0}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -2,3 +2,3 @@
        	            	  X: (float32) 0,
        	            	- Y: (float32) 5
        	            	+ Y: (float32) 0
        	            	 }
        	Test:       	Test_canvas_Dragged
FAIL
FAIL	fyne.io/fyne/v2/internal/driver/mobile	3.415s
...

internal/driver/glfw/testdata/menu_bar_hovered_content.png:

internal/driver/glfw/testdata/failed/menu_bar_hovered_content.png:

1. Do these tests fail for anybody else?
2. The test output contains thousands of lines of binary diff output. As far as I understand, this is the diff of two PNG files: A screenshots of an actual Fyne window and the expected screenshot. Looking at these images helps me to understand what's wrong. But looking at thousands of hex numbers is pointless. I think we should skip the printing of hex diffs if they are longer than a few bytes (if this is possible). → PR for this: go test: Skip printing diff of image files #6140

[andydotxyz]

That image test seems to be fragile. Sometimes it fails for me but not always in exactly that way.

Perhaps the menu bar theme application is not working as well as we thought?

[MaxGyver83]

I'm going to look into this.

[MaxGyver83]

git bisect leads me to this commit: 1068615 ("More GLFW test race fixes").

[MaxGyver83]

See my fix here: #6148 (or call it workaround if you like 😄 )

[MaxGyver83]

Regarding the failing Test_canvas_Dragged:

I have run git bisect on this. It led me to the breaking change: ab6b85f. Since this commit, func (s *Scroll) Dragged isn't defined anymore for non-mobile builds/test runs. How to handle this? This test should only be run when -tags mobile is set. Or the result should depend on the mobile tag.

[MaxGyver83]

See #6149 for a fix.

[andydotxyz]

This is resolved thanks to @MaxGyver83 #6163 - thanks