fix(flyteidl2): rename ActionMetadata.funtion_name to function_name#7697
fix(flyteidl2): rename ActionMetadata.funtion_name to function_name#7697vipulbhasin23 wants to merge 4 commits into
Conversation
Fixes a typo in the ActionMetadata proto field (field number 13 unchanged, wire-compatible) and updates the two backend Go call sites in run_service.go. Generated stubs under gen/ will be regenerated via CI's /regen after the PR is opened. Signed-off-by: Vipul Bhasin <vipulbhasin22@gmail.com>
|
/regen |
|
The Looking at the logs, the It looks like the workflow doesn't currently handle PRs opened from forks (it would need to check out
Happy to make the manual edits under |
Signed-off-by: Vipul Bhasin <vipulbhasin22@gmail.com>
3f23230 to
4f7f079
Compare
…name-typo # Conflicts: # gen/rust/src/flyteidl2.app.rs
|
conflict resolved, regenerated stubs verified clean, ready for workflow approval and review whenever a maintainer has a moment. |
Tracking issue
Related to #7558
Why are the changes needed?
ActionMetadata.funtion_namehas a typo in its field name (missing "c"). This PR fixes the spelling tofunction_nameacross the proto definition and the one backend Go file that references it.This covers Parts 1-3 of #7558 (proto rename, backend Go usages) as scoped by the issue itself, which calls this out as a complete, standalone contribution. Part 4 (bumping the
flyteidl2dependency inflyteorg/flyte-sdk) is a separate repo and is currently blocked on a new package release, so it's left as a follow-up for a separate PR/contributor.What changes were proposed in this pull request?
ActionMetadata.funtion_nametofunction_nameinflyteidl2/workflow/run_definition.proto(field number13unchanged, so this is wire-compatible).runs/service/run_service.go(actionMetadataFromModelandconvertNodeUpdateToEnrichedProto) to use the correctedFunctionNamefield name.gen/are intentionally not hand-edited in this PR — commenting/regenon this PR will trigger CI to regenerate them.How was this patch tested?
go build ./runs/...(will fail until/regenruns, since the generated struct still has the old field name — expected).grep -rn "funtion" . | grep -v "/gen/"returns nothing.Labels
changed
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
Docs link