Skip to content

fix(flyteidl2): rename ActionMetadata.funtion_name to function_name#7697

Open
vipulbhasin23 wants to merge 4 commits into
flyteorg:mainfrom
vipulbhasin23:fix/rename-funtion-name-typo
Open

fix(flyteidl2): rename ActionMetadata.funtion_name to function_name#7697
vipulbhasin23 wants to merge 4 commits into
flyteorg:mainfrom
vipulbhasin23:fix/rename-funtion-name-typo

Conversation

@vipulbhasin23

Copy link
Copy Markdown

Tracking issue

Related to #7558

Why are the changes needed?

ActionMetadata.funtion_name has a typo in its field name (missing "c"). This PR fixes the spelling to function_name across the proto definition and the one backend Go file that references it.

This covers Parts 1-3 of #7558 (proto rename, backend Go usages) as scoped by the issue itself, which calls this out as a complete, standalone contribution. Part 4 (bumping the flyteidl2 dependency in flyteorg/flyte-sdk) is a separate repo and is currently blocked on a new package release, so it's left as a follow-up for a separate PR/contributor.

What changes were proposed in this pull request?

  • Renamed the proto field ActionMetadata.funtion_name to function_name in flyteidl2/workflow/run_definition.proto (field number 13 unchanged, so this is wire-compatible).
  • Updated the two call sites in runs/service/run_service.go (actionMetadataFromModel and convertNodeUpdateToEnrichedProto) to use the corrected FunctionName field name.
  • Generated stubs under gen/ are intentionally not hand-edited in this PR — commenting /regen on this PR will trigger CI to regenerate them.

How was this patch tested?

  • go build ./runs/... (will fail until /regen runs, since the generated struct still has the old field name — expected).
  • grep -rn "funtion" . | grep -v "/gen/" returns nothing.

Labels

changed

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Stack

Docs link

Fixes a typo in the ActionMetadata proto field (field number 13
unchanged, wire-compatible) and updates the two backend Go call
sites in run_service.go. Generated stubs under gen/ will be
regenerated via CI's /regen after the PR is opened.

Signed-off-by: Vipul Bhasin <vipulbhasin22@gmail.com>
@vipulbhasin23

Copy link
Copy Markdown
Author

/regen

@vipulbhasin23

Copy link
Copy Markdown
Author

The /regen workflow failed: https://github.com/flyteorg/flyte/actions/runs/29914379379

Looking at the logs, the Checkout code step in .github/workflows/regenerate-on-comment.yml checks out repository: flyteorg/flyte with ref: <PR head ref>, but this PR's branch (fix/rename-funtion-name-typo) only exists on my fork (vipulbhasin23/flyte), not on flyteorg/flyte itself:

Syncing repository: flyteorg/flyte
...
fatal: A branch or tag with the name 'fix/rename-funtion-name-typo' could not be found

It looks like the workflow doesn't currently handle PRs opened from forks (it would need to check out pull_request.head.repo rather than assuming the branch lives in the base repo). Since I don't have write access to trigger this myself, could a maintainer either:

  • run the regen manually and push the resulting gen/ changes to this branch, or
  • point me to the right way to get the stubs regenerated as an external contributor?

Happy to make the manual edits under gen/ myself if that's preferred instead.

Signed-off-by: Vipul Bhasin <vipulbhasin22@gmail.com>
@vipulbhasin23
vipulbhasin23 force-pushed the fix/rename-funtion-name-typo branch from 3f23230 to 4f7f079 Compare July 24, 2026 04:04
@vipulbhasin23
vipulbhasin23 marked this pull request as ready for review July 24, 2026 04:10
@vipulbhasin23

Copy link
Copy Markdown
Author

conflict resolved, regenerated stubs verified clean, ready for workflow approval and review whenever a maintainer has a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant