Hi! :) I noticed a small (potential) bug. In bigint, addition(), carry should be reset to 0 whenever the current sum does not produce a carry (otherwise it would keep its old value from the previous digit).
As an example:
19 + 11
- adding the ones: 9 + 1 = 10 so carry = 1
- adding the tens: 1 + 1 + 1 = 3, no new carry
here, carry stays 1, so you would append 1 at the end.
Fix: add a carry = 0 in the else block (line 101)
Hi! :) I noticed a small (potential) bug. In bigint, addition(), carry should be reset to 0 whenever the current sum does not produce a carry (otherwise it would keep its old value from the previous digit).
As an example:
19 + 11
here, carry stays 1, so you would append 1 at the end.
Fix: add a carry = 0 in the else block (line 101)