Fix upgrade-dependencies workflow

Author: fardjad

.github/workflows/upgrade-dependencies.yml

@@ -24,29 +24,33 @@ jobs:
             ${{ runner.os }}-build-${{ env.cache-name }}-
             ${{ runner.os }}-build-
             ${{ runner.os }}-
-      - name: Create a PR
-        id: upgrade-dependencies
+      - name: Setup Git
         run: |
-          set -e
-
           git config --local user.name "github-actions[bot]"
           git config --local user.email "github-actions[bot]@users.noreply.github.com"
           git config --local pull.rebase true
 
-          npm ci --quiet --no-progress
-          npx ncu
-          npm i --quiet --no-progress
-          npm audit fix --quiet --no-progress || true
-          npm run fix || true
-
-          if git diff-index --quiet HEAD --; then
-            # no changes
-            exit 0
-          fi
-
           # work around "insufficient permission for adding an object to repository database .git/object" issue
           sudo chmod -R ugo+rwX .git
+      - name: Check for updates
+        id: check-updates
+        run: |
+          set -ex
+          npm ci &> /dev/null
+          npx ncu
+          npm i &> /dev/null
+          npm audit fix --quiet --no-progress --no-fund || true
+          npm run fix &> /dev/null || true
 
+          git add -u
+          git update-index --refresh 
+          if ! git diff-index --quiet HEAD --; then
+            echo "is-changed=1" >> $GITHUB_OUTPUT
+          fi
+      - name: Create a PR
+        if: steps.check-updates.outputs.is-changed
+        id: create-pr
+        run: |
           npm version patch
           PKG_VERSION="$(node -e 'process.stdout.write(require("./package.json").version)')"
 
@@ -65,14 +69,14 @@ jobs:
           git push "${REMOTE_REPO}" "HEAD:${NEW_BRANCH}"
 
           PR_URL=$(gh pr create -B "${CURRENT_BRANCH}" -H "${NEW_BRANCH}" -f)
-          echo "PR_URL=${PR_URL}" >> $GITHUB_OUTPUT
+          echo "pr-url=${PR_URL}" >> $GITHUB_OUTPUT
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: Approve and merge the PR
+        if: steps.create-pr.outputs.pr-url
         run: |
-          set -e
           gh pr review --approve "${PR_URL}"
           gh pr merge --auto --delete-branch --rebase "${PR_URL}"
         env:
           GITHUB_TOKEN: ${{ secrets.GH_PAT }}
-          PR_URL: ${{ steps.upgrade-dependencies.outputs.PR_URL }}
+          PR_URL: ${{ steps.create-pr.outputs.pr-url }}

.ncurc.json

@@ -1,4 +1,3 @@
 {
-  "upgrade": true,
-  "silent": true
+  "upgrade": true
 }