Commit d70f88e
committed
fix(meos): proto extra_fields + Werror unused-param in aggregations
Two adjacent compile-breakers found while validating the codegen output of
PR MobilityDB#21 against the latest mariana/main:
1. SerializableAggregationFunction proto declares only {type, on_field,
as_field}. The 5 MEOS aggregations landing in MobilityDB#16/MobilityDB#17 read additional
fields out of the proto (vidA/vidB/dMeet/...), so they need the extra
field. Adds:
repeated SerializableFunction extra_fields = 4;
Backwards-compatible (tag 4, new repeated). Aggregations whose extra
fields are absent continue to deserialize unchanged.
2. CrossDistance/PairMeeting/TemporalLength aggregations carry an unused
PipelineMemoryProvider& parameter on lower(). Werror=-Wunused-parameter
turns that into a build failure. Annotates the parameter [[maybe_unused]]
at the call site — no behavior change, intent stays visible to readers
who later wire memory into the lowering.
Verified locally on the mobilitynebula-v2 dev image (MEOS baked in):
cmake --build build-w1 --target nes-physical-operators -j 4
→ [110/111] Linking libnes-physical-operators-registry.a
→ [111/111] Linking libnes-physical-operators.a
Stacks on MobilityDB#21 only because that is the active codegen branch where the
breakage surfaced; the diff itself is independent of any codegen output.1 parent 4f60e2e commit d70f88e
4 files changed
Lines changed: 4 additions & 3 deletions
File tree
- grpc
- nes-physical-operators/src/Aggregation/Function/Meos
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| 69 | + | |
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
119 | | - | |
| 119 | + | |
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
| 118 | + | |
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| |||
nes-physical-operators/src/Aggregation/Function/Meos/TemporalLengthAggregationPhysicalFunction.cpp
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| |||
0 commit comments