System.Logger.isLoggable returns true for any level

[4e6]

Issue

In the current setup java.lang.System.Logger.isLoggable always returns true.

enso/lib/java/ydoc-server/src/main/java/org/enso/ydoc/server/Ydoc.java

Line 18 in 745e8b0

private static final System.Logger LOG = System.getLogger(Ydoc.class.getName());

enso/lib/java/ydoc-server/src/main/java/org/enso/ydoc/server/Ydoc.java

Line 299 in 745e8b0

var isDebug = LOG.isLoggable(System.Logger.Level.DEBUG);

Currently isDebug == true always

Info

LogbackSetup sets loglevel to TRACE. Math.min(TRACE, anything) always returns TRACE because it is the lowest level.

enso/lib/scala/logging-service-logback/src/main/java/org/enso/logging/service/logback/LogbackSetup.java

Lines 447 to 454 in 745e8b0

	// Root's log level is set to the minimal required log level.
	// Log level is controlled by `ThresholdFilter` instead, allowing is to specify different
	// log levels for different outputs.
	var minLevelInt = Math.min(Level.TRACE.toInt(), level.toInt());
	var minLevel =
	ch.qos.logback.classic.Level.convertAnSLF4JLevel(Level.intToLevel(minLevelInt));
	logger.setLevel(minLevel);

Then SystemViaSlf4jLogger checks the Logback logger's effective level (TRACE), resulting in true for any level

enso/lib/scala/logging-config/src/main/java/org/enso/logging/config/systemlogger/SystemViaSlf4jLogger.java

Lines 21 to 23 in 745e8b0

	public boolean isLoggable(Level level) {
	return delegate.isEnabledForLevel(at(level));
	}

[JaroslavTulach]

Minimal required log is --log-level value (or minimal of --vm.D=...Logger.level= values). So I would start with:

diff --git lib/scala/logging-config/src/main/java/org/enso/logging/config/systemlogger/SystemViaSlf4jLogger.java lib/scala/logging-config/src/main/java/org/enso/logging/config/systemlogger/SystemViaSlf4jLogger.java
index eda95e9839..d93481fc44 100644
--- lib/scala/logging-config/src/main/java/org/enso/logging/config/systemlogger/SystemViaSlf4jLogger.java
+++ lib/scala/logging-config/src/main/java/org/enso/logging/config/systemlogger/SystemViaSlf4jLogger.java
@@ -19,7 +19,9 @@ final class SystemViaSlf4jLogger implements System.Logger {
 
   @Override
   public boolean isLoggable(Level level) {
-    return delegate.isEnabledForLevel(at(level));
+    var r = delegate.isEnabledForLevel(at(level));
+      System.err.println("isLoggable(" + getName() + ", " + level + ") = " + r);
+      return r;
   }
 
   @Override
diff --git lib/scala/logging-service-logback/src/main/java/org/enso/logging/service/logback/LogbackSetup.java lib/scala/logging-service-logback/src/main/java/org/enso/logging/service/logback/LogbackSetup.java
index 80e2524659..86c02d4e7f 100644
--- lib/scala/logging-service-logback/src/main/java/org/enso/logging/service/logback/LogbackSetup.java
+++ lib/scala/logging-service-logback/src/main/java/org/enso/logging/service/logback/LogbackSetup.java
@@ -447,7 +447,7 @@ public final class LogbackSetup extends LoggerSetup {
       // Root's log level is set to the minimal required log level.
       // Log level is controlled by `ThresholdFilter` instead, allowing is to specify different
       // log levels for different outputs.
-      var minLevelInt = Math.min(Level.TRACE.toInt(), level.toInt());
+      var minLevelInt = Math.max(Level.TRACE.toInt(), level.toInt());
       var minLevel =
           ch.qos.logback.classic.Level.convertAnSLF4JLevel(Level.intToLevel(minLevelInt));
 

but I am not sure of all the consequences.

[4e6]

-      var minLevelInt = Math.min(Level.TRACE.toInt(), level.toInt());
+      var minLevelInt = Math.max(Level.TRACE.toInt(), level.toInt());

The root logger is set to TRACE to allow --vm.D=...Logger.level= overrides. For example, if you set root logger to INFO, then you would not be able to display any DEBUG messages level with --vm.D=org.enso.Logger.level=debug override. They will be filtered out by the root logger.

Another issue is that isLoggable does not respect the --vm.D=...Logger.level= overrides