feat: fluent interface pattern on registerPlugin in Univer class#6740
Open
kenny-not-dead wants to merge 1 commit into
Open
feat: fluent interface pattern on registerPlugin in Univer class#6740kenny-not-dead wants to merge 1 commit into
kenny-not-dead wants to merge 1 commit into
Conversation
e28a612 to
2bce752
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #xxx
The Univer class has a method for registering multiple plugins. It also allows for individual registration using the appropriate method, as documented in some places. It is proposed to expand the ability to use a fluent interface pattern similar to the RXJS method for registrations of the form
univer
.registerPlugin(pluginA)
.registerPlugin(pluginB)
With this approach, it can increase some of the code's readability, and what's important is that it's not a breaking change, but only an additional feature.
I demonstrated this approach using the existing example from the documents.
up to you
Pull Request Checklist